Skip to content

[HOLD for payment 2024-03-22] [$250] Settings - Back button looped when navigated on Contact Methods page several #38296

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Found when validating PR : #35446

Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+omadm28@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: for Desktop or Web user should resize window to mobile view

  1. Open app
  2. Tap on Profile icon in bottom
  3. Tap on Profile
  4. Tap on "Contact Method"
  5. Tap on Back button
  6. Repeat 4-5 steps three or more times in a row
  7. Tap on back button

Expected Result:

User should be navigated back on account Settings page

Actual Result:

User remains on the Profile settings page when tapped on back button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6413266_1710407411530.screen-20240314-110550.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c9704b9b31d6d994
  • Upwork Job ID: 1768267455977009152
  • Last Price Increase: 2024-03-14
Issue OwnerCurrent Issue Owner: @kadiealexander

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 14, 2024
  2. melvin-bot commented on Mar 14, 2024

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. github-actions commented on Mar 14, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Mar 14, 2024

    @melvin-bot

    Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. izarutskaya commented on Mar 14, 2024

    @izarutskaya
    Author

    @danieldoglas I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Mar 14, 2024

    @izarutskaya
    Author

    We think that this bug might be related to #vip-vsb
    CC @quinthar

  7. mountiny commented on Mar 14, 2024

    @mountiny
    Contributor
  8. mountiny commented on Mar 14, 2024

    @mountiny
    Contributor

    cc @abzokhattab @ntdiary from the linked PR too

  9. 48 remaining items

  10. melvin-bot commented on Mar 18, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-25. 🎊

    For reference, here are some details about the assignees on this issue:

    • @akinwale requires payment (Needs manual offer from BZ)
    • @abzokhattab requires payment (Needs manual offer from BZ)
  11. melvin-bot commented on Mar 18, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  12. akinwale commented on Mar 20, 2024

    @akinwale
    Contributor
    • [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
    • [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    #37421 was identified as the source of the regression.

    • [@akinwale] Determine if we should create a regression test for this bug.
    • [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Steps

    1. Launch Expensify NewDot on mobile (mWeb or native iOS/Android).
    2. Tap on the Profile icon.
    3. Tap on Profile.
    4. Select "Contact methods".
    5. Navigate back.
    6. Navigate back a second time.
    7. Verify that the Profile page does not display after the second back navigation action.

    Do we agree 👍 or 👎?

  13. akinwale commented on Mar 20, 2024

    @akinwale
    Contributor

    @kadiealexander Just noting that the correct payment due date is 2024-03-22 since this was deployed to production on 2024-03-15.

    Also, there's an error with the automatic offers. I am unable to accept mine on Upwork.

  14. changed the title [-][HOLD for payment 2024-03-25] [HOLD for payment 2024-03-22] [$250] Settings - Back button looped when navigated on Contact Methods page several[/-] [+][HOLD for payment 2024-03-22] [$250] Settings - Back button looped when navigated on Contact Methods page several[/+] on Mar 21, 2024
  15. kadiealexander commented on Mar 21, 2024

    @kadiealexander
    Contributor

    Payouts due:

    Upwork job is here.

    Please accept the Upwork offers we've sent across!

  16. abzokhattab commented on Mar 21, 2024

    @abzokhattab
    Contributor

    Thanks @kadiealexander for the followup

    i cannot accept all manual offers sent from Expensify.. i get the following error message

    image

    I have opened a discussion on slack on that but no answer so far.

  17. akinwale commented on Mar 21, 2024

    @akinwale
    Contributor

    Upwork job is here.

    Please accept the Upwork offers we've sent across!

    I think new offers may need to be sent.

  18. kadiealexander commented on Mar 21, 2024

    @kadiealexander
    Contributor

    I've manually sent offers just now, can you both check and see if you're able to accept them?

  19. abzokhattab commented on Mar 21, 2024

    @abzokhattab
    Contributor

    Thank you! Accepted.

  20. kadiealexander commented on Mar 21, 2024

    @kadiealexander
    Contributor

    Awesome! Will pay out on the 22nd :)

  21. akinwale commented on Mar 21, 2024

    @akinwale
    Contributor

    I've manually sent offers just now, can you both check and see if you're able to accept them?

    Accepted. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions