You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-03-22] [$250] Settings - Back button looped when navigated on Contact Methods page several #38296
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@danieldoglas I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@akinwale] Determine if we should create a regression test for this bug.
[@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@akinwale] The PR that introduced the bug has been identified. Link to the PR:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
#37421 was identified as the source of the regression.
[@akinwale] Determine if we should create a regression test for this bug.
[@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Steps
Launch Expensify NewDot on mobile (mWeb or native iOS/Android).
Tap on the Profile icon.
Tap on Profile.
Select "Contact methods".
Navigate back.
Navigate back a second time.
Verify that the Profile page does not display after the second back navigation action.
changed the title [-][HOLD for payment 2024-03-25] [HOLD for payment 2024-03-22] [$250] Settings - Back button looped when navigated on Contact Methods page several[/-][+][HOLD for payment 2024-03-22] [$250] Settings - Back button looped when navigated on Contact Methods page several[/+]on Mar 21, 2024
Activity
melvin-bot commentedon Mar 14, 2024
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Mar 14, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 14, 2024
Triggered auto assignment to @danieldoglas (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.izarutskaya commentedon Mar 14, 2024
@danieldoglas I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Mar 14, 2024
We think that this bug might be related to #vip-vsb
CC @quinthar
mountiny commentedon Mar 14, 2024
@kosmydel
mountiny commentedon Mar 14, 2024
cc @abzokhattab @ntdiary from the linked PR too
48 remaining items
melvin-bot commentedon Mar 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-25. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 18, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
akinwale commentedon Mar 20, 2024
#37421 was identified as the source of the regression.
Regression Test Steps
Do we agree 👍 or 👎?
akinwale commentedon Mar 20, 2024
@kadiealexander Just noting that the correct payment due date is 2024-03-22 since this was deployed to production on 2024-03-15.
Also, there's an error with the automatic offers. I am unable to accept mine on Upwork.
[-][HOLD for payment 2024-03-25] [HOLD for payment 2024-03-22] [$250] Settings - Back button looped when navigated on Contact Methods page several[/-][+][HOLD for payment 2024-03-22] [$250] Settings - Back button looped when navigated on Contact Methods page several[/+]kadiealexander commentedon Mar 21, 2024
Payouts due:
Upwork job is here.
Please accept the Upwork offers we've sent across!
abzokhattab commentedon Mar 21, 2024
Thanks @kadiealexander for the followup
i cannot accept all manual offers sent from Expensify.. i get the following error message
I have opened a discussion on slack on that but no answer so far.
akinwale commentedon Mar 21, 2024
I think new offers may need to be sent.
kadiealexander commentedon Mar 21, 2024
I've manually sent offers just now, can you both check and see if you're able to accept them?
abzokhattab commentedon Mar 21, 2024
Thank you! Accepted.
kadiealexander commentedon Mar 21, 2024
Awesome! Will pay out on the 22nd :)
akinwale commentedon Mar 21, 2024
Accepted. Thanks!