Skip to content

[HOLD for payment 2024-04-05] [Simplified Collect][Distance rates] - Error shows up when disabling and renaming distance rate #38815

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • User is admin of Collect workspace
  1. Go to staging.new.expensify.com
  2. Go to Profile > Workspaces > Collect workspace
  3. Go to Distance rates
  4. Add a distance rate
  5. Click on the distance rate added in Step 4
  6. Toggle off the Enable rate button
  7. Click Rate and edit the rate

Expected Result:

App will save the new settings made in Step 6 and 7

Actual Result:

Error shows up when disabling and renaming distance rate

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423392_1711126287997.20240323_004850.mp4

View all open jobs on GitHub

Activity

  1. github-actions commented on Mar 22, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Mar 22, 2024

    @melvin-bot

    Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. lanitochka17 commented on Mar 22, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-control

  4. lanitochka17 commented on Mar 22, 2024

    @lanitochka17
    Author

    @stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collecton Mar 22, 2024
  6. changed the title [-]Distance rates - Error shows up when disabling and renaming distance rate[/-] [+][Simplified Collect][Distance rates] - Error shows up when disabling and renaming distance rate[/+] on Mar 22, 2024
  7. luacmartins commented on Mar 22, 2024

    @luacmartins
    Contributor

    This is not a blocker since this feature is not available to users yet.

  8. luacmartins commented on Mar 22, 2024

    @luacmartins
    Contributor
  9. 3 remaining items

  10. luacmartins commented on Mar 22, 2024

    @luacmartins
    Contributor

    This is the error that I get. This was already fixed here
    Screenshot 2024-03-22 at 4 47 14 PM

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 29, 2024
  12. changed the title [-][Simplified Collect][Distance rates] - Error shows up when disabling and renaming distance rate[/-] [+][HOLD for payment 2024-04-05] [Simplified Collect][Distance rates] - Error shows up when disabling and renaming distance rate[/+] on Mar 29, 2024
  13. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-05. 🎊

  15. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  16. luacmartins commented on Apr 5, 2024

    @luacmartins
    Contributor

    This is done

  17. moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collecton Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions