Skip to content

[HOLD for payment 2024-04-05] [$500] Workspace - #admin room with messages shows skeleton loading after workspace is deleted #38839

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.56-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com.
  2. Create a new workspace.
  3. Go to #admin room.
  4. Send a message.
  5. Delete the workspace.
  6. Go to #admin room.

Expected Result:

#admin room will not show skeleton loading after the workspace is deleted.

Actual Result:

#admin room shows skeleton loading after the workspace is deleted.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423448_1711129084965.20240323_013502.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0190baa2ce2890e3e7
  • Upwork Job ID: 1772371688906227712
  • Last Price Increase: 2024-03-25
  • Automatic offers:
    • ishpaul777 | Contributor | 0

Activity

  1. kbecciv commented on Mar 22, 2024

    @kbecciv
    Author

    We think that this bug might be related to #vip-vsb

  2. github-actions commented on Mar 22, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on Mar 22, 2024

    @melvin-bot

    Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. aldo-expensify commented on Mar 22, 2024

    @aldo-expensify
    Contributor

    The GetOlderActions command is erroring out, sample logs: 86894ae17a5e2d72-YVR

    image

  5. aldo-expensify commented on Mar 22, 2024

    @aldo-expensify
    Contributor

    Seems like the functions loadOlderChats and loadNewerChats gets called in a infinite loop:

    image

    The InvertedFlatList is calling them here:

    onEndReached={loadOlderChats}
    onEndReachedThreshold={0.75}
    onStartReached={loadNewerChats}
    onStartReachedThreshold={0.75}

  6. aldo-expensify commented on Mar 25, 2024

    @aldo-expensify
    Contributor

    Adding external and bug to see if we can get a contributor to help here

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 25, 2024
  8. 37 remaining items

  9. aldo-expensify commented on Mar 28, 2024

    @aldo-expensify
    Contributor

    @mallenexpensify : @ishpaul777 ended up reviewing

  10. removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 28, 2024
  11. melvin-bot commented on Mar 28, 2024

    @melvin-bot

    📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  12. ishpaul777 commented on Mar 28, 2024

    @ishpaul777
    Contributor

    hmm, this doesn't require a payment i was c+ on the offending PR

  13. aldo-expensify commented on Mar 28, 2024

    @aldo-expensify
    Contributor

    ohh thanks for clearing that up!

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 29, 2024
  15. changed the title [-][$500] Workspace - #admin room with messages shows skeleton loading after workspace is deleted[/-] [+][HOLD for payment 2024-04-05] [$500] Workspace - #admin room with messages shows skeleton loading after workspace is deleted[/+] on Mar 29, 2024
  16. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-05. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions