You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-04-05] [$500] Workspace - #admin room with messages shows skeleton loading after workspace is deleted #38839
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
changed the title [-][$500] Workspace - #admin room with messages shows skeleton loading after workspace is deleted[/-][+][HOLD for payment 2024-04-05] [$500] Workspace - #admin room with messages shows skeleton loading after workspace is deleted[/+]on Mar 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need, the linked PR was huge and caused many deploy blockers
[@aldo-expensify] Determine if we should create a regression test for this bug: I think this is already caught by existing regression tests
[@aldo-expensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/a
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/a
Activity
kbecciv commentedon Mar 22, 2024
We think that this bug might be related to #vip-vsb
github-actions commentedon Mar 22, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 22, 2024
Triggered auto assignment to @aldo-expensify (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.aldo-expensify commentedon Mar 22, 2024
The

GetOlderActionscommand is erroring out, sample logs: 86894ae17a5e2d72-YVRaldo-expensify commentedon Mar 22, 2024
Seems like the functions loadOlderChats and loadNewerChats gets called in a infinite loop:
The
InvertedFlatListis calling them here:App/src/pages/home/report/ReportActionsList.tsx
Lines 610 to 613 in 81787f5
aldo-expensify commentedon Mar 25, 2024
Adding
externalandbugto see if we can get a contributor to help here37 remaining items
aldo-expensify commentedon Mar 28, 2024
@mallenexpensify : @ishpaul777 ended up reviewing
melvin-bot commentedon Mar 28, 2024
📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
ishpaul777 commentedon Mar 28, 2024
hmm, this doesn't require a payment i was c+ on the offending PR
aldo-expensify commentedon Mar 28, 2024
ohh thanks for clearing that up!
[-][$500] Workspace - #admin room with messages shows skeleton loading after workspace is deleted[/-][+][HOLD for payment 2024-04-05] [$500] Workspace - #admin room with messages shows skeleton loading after workspace is deleted[/+]melvin-bot commentedon Mar 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 29, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: