Skip to content

[HOLD for payment 2024-04-09] [$250] Web - Video - Expand video button isn't highlighted when hovered on #38841

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.56-0
Reproducible in staging?: y
Reproducible in production?: y
Issue found when executing PR: #36945
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to a conversation
  2. Attach a video.
  3. Play the video. The expand video button appears alongside the video
  4. Hover the mouse icon on the expand button

Expected Result:

Expand video button is highlighted when hovered on as other buttons like pause, full screen etc.

Actual Result:

Expand video button is not highlighted when hovered on

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423501_1711131683574.2024-03-22_21-10-04.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019dec26faa8f28e37
  • Upwork Job ID: 1772265129297416192
  • Last Price Increase: 2024-03-25
  • Automatic offers:
    • GandalfGwaihir | Contributor | 0

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 22, 2024
  2. melvin-bot commented on Mar 22, 2024

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. kbecciv commented on Mar 22, 2024

    @kbecciv
    Author

    We think that this bug might be related to #vip-vsb

  4. kbecciv commented on Mar 22, 2024

    @kbecciv
    Author

    @sonialiap I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  5. allgandalf commented on Mar 22, 2024

    @allgandalf
    Contributor

    Regression from #36945

    Update the styles inside PressableWithFeedback to style={[styles.videoIconButton, isHovered && [styles.videoIconButtonHovered, hoverStyle], style]}

  6. ntdiary commented on Mar 23, 2024

    @ntdiary
    Contributor
    test.mp4

    Eh, this is consistent with production, and if we indeed want the button to be highlighted, it's also easy to change the code. :)

  7. allgandalf commented on Mar 23, 2024

    @allgandalf
    Contributor

    Opps, my bad :) i thought this is a deploy blocker might be related ro the PR, extremely sorry @ntdiary

  8. allgandalf commented on Mar 23, 2024

    @allgandalf
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Expand video button isn't highlighted when hovered on

    What is the root cause of that problem?

    We have set style which doesn't highlight the bg when hovered:

    <IconButton
    src={Expensicons.Expand}
    style={[styles.videoExpandButton]}
    hoverStyle={StyleUtils.getBackgroundColorStyle(theme.videoPlayerBG)}

    What changes do you think we should make in order to solve the problem?

    Remove the hoverStyle style, let it take the default style of the Icon component

    Result Video

    simplescreenrecorder-2024-03-23_06.41.14.mp4
  9. ShridharGoel commented on Mar 23, 2024

    @ShridharGoel
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Video - Expand video button isn't highlighted when hovered on.

    What is the root cause of that problem?

    hoverStyle uses theme.videoPlayerBG which is set to ${colors.productDark100}cc.

    <IconButton
    src={Expensicons.Expand}
    style={[styles.videoExpandButton]}
    hoverStyle={StyleUtils.getBackgroundColorStyle(theme.videoPlayerBG)}
    tooltipText={translate('videoPlayer.expand')}
    onPress={onShowModalPress}
    small
    />

    What changes do you think we should make in order to solve the problem?

    Use iconMenuHovered.

    <IconButton
        src={Expensicons.Expand}
        style={[styles.videoExpandButton]}
        hoverStyle={StyleUtils.getBackgroundColorStyle(theme.iconMenuHovered)}
        tooltipText={translate('videoPlayer.expand')}
        onPress={onShowModalPress}
        small
    />
    

    This will work well for both light and dark themes.

  10. self-assigned this
    on Mar 25, 2024
  11. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 25, 2024
  12. 20 remaining items

  13. changed the title [-][$250] Web - Video - Expand video button isn't highlighted when hovered on[/-] [+][HOLD for payment 2024-04-09] [$250] Web - Video - Expand video button isn't highlighted when hovered on[/+] on Apr 2, 2024
  14. melvin-bot commented on Apr 2, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Apr 2, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-09. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Apr 2, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
    • [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@sobitneupane] Determine if we should create a regression test for this bug.
    • [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. sonialiap commented on Apr 9, 2024

    @sonialiap
    Contributor

    Payment summary

  18. sobitneupane commented on Apr 11, 2024

    @sobitneupane
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

    #36945

    • [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    #36945 (comment)

    • [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    This should have been caught in the previous PR review. We don't need to add a new checklist.

    • [@sobitneupane] Determine if we should create a regression test for this bug.

    Yes.

    • [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    #38841 (comment)

  19. sobitneupane commented on Apr 11, 2024

    @sobitneupane
    Contributor

    Regression Test Propsal

    1. Navigate to a conversation
    2. Attach a video.
    3. Play the video. The expand video button appears alongside the video
    4. Hover the mouse icon on the expand button
    5. Verify that the expand video button is highlighted when hovered on as other buttons like pause.

    Do we agree 👍 or 👎

  20. sonialiap commented on Apr 11, 2024

    @sonialiap
    Contributor

    Thanks!

  21. JmillsExpensify commented on Apr 11, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @sobitneupane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions