You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-04-09] [$250] Web - Video - Expand video button isn't highlighted when hovered on #38841
Version Number: 1.4.56-0 Reproducible in staging?: y Reproducible in production?: y Issue found when executing PR:#36945 Issue reported by: Applause - Internal Team
Action Performed:
Navigate to a conversation
Attach a video.
Play the video. The expand video button appears alongside the video
Hover the mouse icon on the expand button
Expected Result:
Expand video button is highlighted when hovered on as other buttons like pause, full screen etc.
Actual Result:
Expand video button is not highlighted when hovered on
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
@sonialiap I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
changed the title [-][$250] Web - Video - Expand video button isn't highlighted when hovered on[/-][+][HOLD for payment 2024-04-09] [$250] Web - Video - Expand video button isn't highlighted when hovered on[/+]on Apr 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane] Determine if we should create a regression test for this bug.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
This should have been caught in the previous PR review. We don't need to add a new checklist.
[@sobitneupane] Determine if we should create a regression test for this bug.
Yes.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Mar 22, 2024
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.kbecciv commentedon Mar 22, 2024
We think that this bug might be related to #vip-vsb
kbecciv commentedon Mar 22, 2024
@sonialiap I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
allgandalf commentedon Mar 22, 2024
Regression from #36945Update the styles insidePressableWithFeedbacktostyle={[styles.videoIconButton, isHovered && [styles.videoIconButtonHovered, hoverStyle], style]}ntdiary commentedon Mar 23, 2024
test.mp4
Eh, this is consistent with production, and if we indeed want the button to be highlighted, it's also easy to change the code. :)
allgandalf commentedon Mar 23, 2024
Opps, my bad :) i thought this is a deploy blocker might be related ro the PR, extremely sorry @ntdiary
allgandalf commentedon Mar 23, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expand video button isn't highlighted when hovered on
What is the root cause of that problem?
We have set style which doesn't highlight the bg when hovered:
App/src/components/VideoPlayerPreview/index.tsx
Lines 92 to 95 in 729d475
What changes do you think we should make in order to solve the problem?
Remove the
hoverStylestyle, let it take the default style of theIconcomponentResult Video
simplescreenrecorder-2024-03-23_06.41.14.mp4
ShridharGoel commentedon Mar 23, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Video - Expand video button isn't highlighted when hovered on.
What is the root cause of that problem?
hoverStyleuses theme.videoPlayerBG which is set to${colors.productDark100}cc.App/src/components/VideoPlayerPreview/index.tsx
Lines 92 to 99 in 191d932
What changes do you think we should make in order to solve the problem?
Use
iconMenuHovered.This will work well for both light and dark themes.
20 remaining items
[-][$250] Web - Video - Expand video button isn't highlighted when hovered on[/-][+][HOLD for payment 2024-04-09] [$250] Web - Video - Expand video button isn't highlighted when hovered on[/+]melvin-bot commentedon Apr 2, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-09. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 2, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
sonialiap commentedon Apr 9, 2024
Payment summary
sobitneupane commentedon Apr 11, 2024
#36945
#36945 (comment)
This should have been caught in the previous PR review. We don't need to add a new checklist.
Yes.
#38841 (comment)
sobitneupane commentedon Apr 11, 2024
Regression Test Propsal
Do we agree 👍 or 👎
sonialiap commentedon Apr 11, 2024
Thanks!
JmillsExpensify commentedon Apr 11, 2024
$250 approved for @sobitneupane