Skip to content

[HOLD for payment 2024-04-05] [$500] [HOLD #38375][Simplified Collect][Taxes] "Custom tax name" does not change the name repeatedly #38859

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Found when validating PR : #38732

Version Number: 1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): sustinov@applausemail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Preconditions:
Configure the OldDot new expensifail account, create a Collect workspace with workspace chat enabled https://sites.google.com/applausemail.com/applause-expensifyproject/wiki-guides/newdot-categories?authuser=0

Steps:

  1. Open https://staging.new.expensify.com/
  2. Log in to the configured account
  3. Navigate to Workspace settings - Taxes - Settings - Custom tax name
  4. Type in any name
  5. Click on the "Save" button
  6. Retry steps 3-5

Expected Result:

"Custom tax name" should change the name when the new name is saved again

Actual Result:

"Custom tax name" does not change the name repeatedly

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6423717_1711140577819.Recording__1457.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c1d92fc91f1c59c3
  • Upwork Job ID: 1772211059605901312
  • Last Price Increase: 2024-03-25

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 23, 2024
  2. melvin-bot commented on Mar 23, 2024

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. github-actions commented on Mar 23, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Mar 23, 2024

    @melvin-bot

    Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. izarutskaya commented on Mar 23, 2024

    @izarutskaya
    Author

    @dylanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

    We think that this bug might be related to the #collect project.

  6. izarutskaya commented on Mar 23, 2024

    @izarutskaya
    Author

    Production

    Recording.2296.mp4
  7. dylanexpensify commented on Mar 25, 2024

    @dylanexpensify
    Contributor

    Confirmed I cannot save/update the custom tax name. cc @nkuoch

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 25, 2024
  9. 30 remaining items

  10. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@c3024] The PR that introduced the bug has been identified. Link to the PR:
    • [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@c3024] Determine if we should create a regression test for this bug.
    • [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • ROLE: @c3024 paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@dylanexpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1772211059605901312/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. luacmartins commented on Apr 8, 2024

    @luacmartins
    Contributor

    Just pending payment

  13. dylanexpensify commented on Apr 9, 2024

    @dylanexpensify
    Contributor

    On it today!

  14. dylanexpensify commented on Apr 9, 2024

    @dylanexpensify
    Contributor

    Payment summary:

    • Contributor+: $500

    Please request/apply!

  15. c3024 commented on Apr 9, 2024

    @c3024
    Contributor

    @dylanexpensify applied on Upwork. Thanks.

  16. dylanexpensify commented on Apr 9, 2024

    @dylanexpensify
    Contributor

    @c3024 offer sent!

  17. c3024 commented on Apr 9, 2024

    @c3024
    Contributor

    accepted!

  18. dylanexpensify commented on Apr 9, 2024

    @dylanexpensify
    Contributor

    Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions