Skip to content

[TS migration] Migrate IOURequestStepTag, IOURequestStepParticipants and IOURequestStepMerchant pages to TypeScript #38916

Closed

Description

@fabioh8010

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

  • src/pages/iou/request/step/IOURequestStepTag.js
  • src/pages/iou/request/step/IOURequestStepParticipants.js
  • src/pages/iou/request/step/IOURequestStepMerchant.js

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 25, 2024
  2. fabioh8010 commented on Mar 25, 2024

    @fabioh8010
    ContributorAuthor

    This issue is internal and will be handled by the TS team.

  3. melvin-bot commented on Mar 25, 2024

    @melvin-bot

    Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. ruben-rebelo commented on Mar 25, 2024

    @ruben-rebelo
    Contributor

    I am Ruben Rebelo from Callstack - expert contributor group. I’d like to work on this job.

  5. added
    NewFeatureSomething to build that is a new item.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 25, 2024
  6. melvin-bot commented on Mar 25, 2024

    @melvin-bot

    Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

  7. melvin-bot commented on Apr 19, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  8. puneetlath commented on May 1, 2024

    @puneetlath
    Contributor

    It seems like this is done and we just need to pay @mananjadhav out. Is that right?

  9. mananjadhav commented on May 1, 2024

    @mananjadhav
    Collaborator

    Yes @puneetlath Can you please post the payment summary?

  10. puneetlath commented on May 1, 2024

    @puneetlath
    Contributor

    Payment summary:

    Thanks everyone!

  11. JmillsExpensify commented on May 1, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions