Skip to content

[$250] [HOLD for payment 2024-04-09] [HOLD for payment 2024-04-05] [Dev] Infinite loop of GetOlderActions calls #39028

Closed

Description

@roryabraham

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: only reproducible on dev at the time of creating - 1.4.56-6 at the time of wriging
Reproducible in staging?: no
Reproducible in production?: no
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1711476371378119?thread_ts=1711147499.521539&cid=C049HHMV9SM

Action Performed:

  1. Open a report
  2. Go offline
  3. Send a message
  4. Delete the message
  5. Go online

Expected Result:

  1. The message you sent and deleted offline should be deleted.
  2. The skeleton indicator should not appear indefinitely on the report. You should not see an infinite loop of GetOlderAction requests in the network tab.

Actual Result:

Skeleton indicator appears and flashes infinitely, along with an infinite loop of GetOlderActions requests.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

https://expensify.slack.com/archives/C049HHMV9SM/p1711476420432379?thread_ts=1711147499.521539&cid=C049HHMV9SM

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017cac9b0408529fb8
  • Upwork Job ID: 1778528999840456704
  • Last Price Increase: 2024-04-11

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 26, 2024
  2. self-assigned this
    on Mar 26, 2024
  3. melvin-bot commented on Mar 26, 2024

    @melvin-bot

    Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. roryabraham commented on Mar 26, 2024

    @roryabraham
    ContributorAuthor

    sup @kevinksullivan. I already have a WIP PR to fix this here. It's an hourly because it's reproducible only on dev. That means that as soon as we deploy staging it will become a deploy blocker

  5. github-actions commented on Mar 27, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Mar 27, 2024

    @melvin-bot

    Current assignee @roryabraham is eligible for the Engineering assigner, not assigning anyone new.

  7. roryabraham commented on Mar 27, 2024

    @roryabraham
    ContributorAuthor

    ok, jumping back into the PR

  8. roryabraham commented on Mar 28, 2024

    @roryabraham
    ContributorAuthor

    Got that PR ready for review: #39024

  9. 23 remaining items

  10. changed the title [-][HOLD for payment 2024-04-09] [HOLD for payment 2024-04-05] [Dev] Infinite loop of GetOlderActions calls[/-] [+][$250] [HOLD for payment 2024-04-09] [HOLD for payment 2024-04-05] [Dev] Infinite loop of GetOlderActions calls[/+] on Apr 11, 2024
  11. melvin-bot commented on Apr 11, 2024

    @melvin-bot
  12. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 11, 2024
  13. melvin-bot commented on Apr 11, 2024

    @melvin-bot

    Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

  14. kevinksullivan commented on Apr 11, 2024

    @kevinksullivan
    Contributor

    @ishpaul777 offer sent, lmk when you accept!

  15. ishpaul777 commented on Apr 11, 2024

    @ishpaul777
    Contributor

    hello 👋 @kevinksullivan, i was not involved in the PR no idea why melvin says i am eligible for payment 🤔

  16. kevinksullivan commented on Apr 11, 2024

    @kevinksullivan
    Contributor

    ah ok, weird haha. Thanks for letting me know. I will close this out then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions