Skip to content

[$500] [QAB] Shortcut - Request money shortcut for workspace remains after workspace is deleted #39051

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.57-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com.
  2. Go to workspace chat.
  3. Request money from the workspace chat.
  4. Delete the workspace.
  5. Click FAB.
  6. Click Request money shortcut.

Expected Result:

After deleting the workspace, Request money shortcut should lead user to select a new participant.

Actual Result:

After deleting the workspace, Request money shortcut for the deleted workspace still remains. Clicking on the shortcut results in not here page.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6428615_1711540647403.shortcut_delete.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016af2ad690a3296e0
  • Upwork Job ID: 1772979000228327424
  • Last Price Increase: 2024-03-28

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 27, 2024
  2. melvin-bot commented on Mar 27, 2024

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. github-actions commented on Mar 27, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Mar 27, 2024

    @melvin-bot

    Triggered auto assignment to @lakchote (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. izarutskaya commented on Mar 27, 2024

    @izarutskaya
    Author

    @mallenexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Mar 27, 2024

    @izarutskaya
    Author

    We think that this bug might be related to #vip-vsb.

  7. allgandalf commented on Mar 27, 2024

    @allgandalf
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Request money shortcut for workspace remains after workspace is deleted

    What is the root cause of that problem?

    We don't check if workspace is archived before display the shortcut:

    ...(props.quickAction && props.quickAction.action
    ? [
    {
    icon: getQuickActionIcon(props.quickAction.action),
    text: translate(getQuickActionTitle(props.quickAction.action)),
    label: translate('quickAction.shortcut'),

    What changes do you think we should make in order to solve the problem?

    Add isArchivedRoom check

    App/src/libs/ReportUtils.ts

    Lines 1106 to 1108 in cd18bef

    function isArchivedRoom(report: OnyxEntry<Report> | EmptyObject): boolean {
    return report?.statusNum === CONST.REPORT.STATUS_NUM.CLOSED && report?.stateNum === CONST.REPORT.STATE_NUM.APPROVED;
    }

    What alternative solutions did you explore? (Optional)

    N/A

  8. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 27, 2024
  9. 37 remaining items

  10. lakchote commented on Apr 15, 2024

    @lakchote
    Contributor

    PR got approved, waiting for another reviewer's approval to be merged.

  11. mallenexpensify commented on Apr 23, 2024

    @mallenexpensify
    Contributor

    PR is on main
    #39413

  12. parasharrajat commented on Apr 24, 2024

    @parasharrajat
    Member

    @Expensify/applause Can we please retest it?

  13. added
    retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause
    on Apr 26, 2024
  14. changed the title [-][HOLD #38051][$500] [QAB] Shortcut - Request money shortcut for workspace remains after workspace is deleted[/-] [+][$500] [QAB] Shortcut - Request money shortcut for workspace remains after workspace is deleted[/+] on Apr 26, 2024
  15. mallenexpensify commented on Apr 26, 2024

    @mallenexpensify
    Contributor

    Taking off hold, added retest-weekly label.

  16. trjExpensify commented on May 2, 2024

    @trjExpensify
    Contributor

    I think this is probably the same as: #41467

    We have a PR up for that, so this can be closed. @Gonals can confirm though!

  17. Gonals commented on May 3, 2024

    @Gonals
    Contributor

    Yep! This should be handled by #41474

  18. trjExpensify commented on May 3, 2024

    @trjExpensify
    Contributor

    Excellllent. Another one bites the dust!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions