You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] [QAB] Shortcut - Request money shortcut for workspace remains after workspace is deleted #39051
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@mallenexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
changed the title [-][HOLD #38051][$500] [QAB] Shortcut - Request money shortcut for workspace remains after workspace is deleted[/-][+][$500] [QAB] Shortcut - Request money shortcut for workspace remains after workspace is deleted[/+]on Apr 26, 2024
Activity
melvin-bot commentedon Mar 27, 2024
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Mar 27, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 27, 2024
Triggered auto assignment to @lakchote (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.izarutskaya commentedon Mar 27, 2024
@mallenexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Mar 27, 2024
We think that this bug might be related to #vip-vsb.
allgandalf commentedon Mar 27, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Request money shortcut for workspace remains after workspace is deleted
What is the root cause of that problem?
We don't check if workspace is archived before display the shortcut:
App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js
Lines 338 to 343 in cd18bef
What changes do you think we should make in order to solve the problem?
Add
isArchivedRoomcheckApp/src/libs/ReportUtils.ts
Lines 1106 to 1108 in cd18bef
What alternative solutions did you explore? (Optional)
N/A
37 remaining items
lakchote commentedon Apr 15, 2024
PR got approved, waiting for another reviewer's approval to be merged.
mallenexpensify commentedon Apr 23, 2024
PR is on main
#39413
parasharrajat commentedon Apr 24, 2024
@Expensify/applause Can we please retest it?
[-][HOLD #38051][$500] [QAB] Shortcut - Request money shortcut for workspace remains after workspace is deleted[/-][+][$500] [QAB] Shortcut - Request money shortcut for workspace remains after workspace is deleted[/+]mallenexpensify commentedon Apr 26, 2024
Taking off hold, added
retest-weeklylabel.trjExpensify commentedon May 2, 2024
I think this is probably the same as: #41467
We have a PR up for that, so this can be closed. @Gonals can confirm though!
Gonals commentedon May 3, 2024
Yep! This should be handled by #41474
trjExpensify commentedon May 3, 2024
Excellllent. Another one bites the dust!