You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-04-15] Distance- Blank space above waypoints when transitioning between request and confirmation page #39053
Version Number: 1.4.57-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat
Click + > Request money > Distance
Enter addresses
Click Next
Proceed to confirmation page
Swipe right to return to previous page.
Expected Result:
When transitioning between confirmation page and distance request page, there will be no blank space above waypoints in distance request page (production behavior)
Actual Result:
When transitioning between confirmation page and distance request page, there is blank space above waypoints in distance request page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@neil-marcellini FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Distance- Blank space above waypoints when transitioning between request and confirmation page[/-][+][HOLD for payment 2024-04-15] Distance- Blank space above waypoints when transitioning between request and confirmation page[/+]on Apr 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
github-actions commentedon Mar 27, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 27, 2024
Triggered auto assignment to @neil-marcellini (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Mar 27, 2024
We think that this bug might be related to #wave-collect - Release 1
lanitochka17 commentedon Mar 27, 2024
@neil-marcellini FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
ZhenjaHorbach commentedon Mar 27, 2024
Looks like a regression from this PR #35302
Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance- Blank space above waypoints when transitioning between request and confirmation page
What is the root cause of that problem?
The main problem with the issue is that when we navigate to another screen we change the current acriveRoute
App/src/pages/iou/request/step/IOURequestStepDistance.js
Line 87 in c4b0bbe
As a result, we change the value here and show the header
App/src/pages/iou/request/step/IOURequestStepDistance.js
Line 229 in c4b0bbe
What changes do you think we should make in order to solve the problem?
To fix this issue we can use useRef to save current isCreatingNewRequestValue
For example :
const isCreatingNewRequest = useRef(isCreatingNewRequestValue)(As alternative useState())Since our header display is limited to the screen and it doesn’t make sense for us to use a dynamic value that depends on the navigation state
What alternative solutions did you explore? (Optional)
As alternative we can use previous logic (
shouldShowWrapper={isEditing})nkdengineer commentedon Mar 28, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance- Blank space above waypoints when transitioning between request and confirmation page
What is the root cause of that problem?
We are determining the current action based on the 'start' word on the route
App/src/pages/iou/request/step/IOURequestStepDistance.js
Line 87 in c4b0bbe
It caused the flicker when the route changed
What changes do you think we should make in order to solve the problem?
We should update like that
What alternative solutions did you explore? (Optional)
DylanDylann commentedon Mar 28, 2024
@cubuspl42 The PR is ready for review: #39053
2 remaining items
[-]Distance- Blank space above waypoints when transitioning between request and confirmation page[/-][+][HOLD for payment 2024-04-15] Distance- Blank space above waypoints when transitioning between request and confirmation page[/+]melvin-bot commentedon Apr 8, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-15. 🎊
melvin-bot commentedon Apr 15, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
melvin-bot commentedon Apr 17, 2024
@neil-marcellini Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
neil-marcellini commentedon Apr 17, 2024
No payment needed to fix a regression.