Skip to content

[HOLD for payment 2024-04-15] Distance- Blank space above waypoints when transitioning between request and confirmation page #39053

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.57-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Click + > Request money > Distance
  4. Enter addresses
  5. Click Next
  6. Proceed to confirmation page
  7. Swipe right to return to previous page.

Expected Result:

When transitioning between confirmation page and distance request page, there will be no blank space above waypoints in distance request page (production behavior)

Actual Result:

When transitioning between confirmation page and distance request page, there is blank space above waypoints in distance request page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6428616_1711540649053.distance_transition.mp4

View all open jobs on GitHub

Activity

  1. github-actions commented on Mar 27, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Mar 27, 2024

    @melvin-bot

    Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. lanitochka17 commented on Mar 27, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-collect - Release 1

  4. lanitochka17 commented on Mar 27, 2024

    @lanitochka17
    Author

    @neil-marcellini FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. ZhenjaHorbach commented on Mar 27, 2024

    @ZhenjaHorbach
    Contributor

    Looks like a regression from this PR #35302

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Distance- Blank space above waypoints when transitioning between request and confirmation page

    What is the root cause of that problem?

    The main problem with the issue is that when we navigate to another screen we change the current acriveRoute

    const isCreatingNewRequest = Navigation.getActiveRoute().includes('start');

    As a result, we change the value here and show the header

    shouldShowWrapper={!isCreatingNewRequest}

    What changes do you think we should make in order to solve the problem?

    To fix this issue we can use useRef to save current isCreatingNewRequestValue

    For example :

    const isCreatingNewRequest = useRef(isCreatingNewRequestValue) (As alternative useState())

    Since our header display is limited to the screen and it doesn’t make sense for us to use a dynamic value that depends on the navigation state

    What alternative solutions did you explore? (Optional)

    As alternative we can use previous logic (shouldShowWrapper={isEditing})

  6. nkdengineer commented on Mar 28, 2024

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Distance- Blank space above waypoints when transitioning between request and confirmation page

    What is the root cause of that problem?

    We are determining the current action based on the 'start' word on the route

    const isCreatingNewRequest = Navigation.getActiveRoute().includes('start');

    It caused the flicker when the route changed

    What changes do you think we should make in order to solve the problem?

    We should update like that

        const isCreatingNewRequest = !(backTo || isEditing)
    

    What alternative solutions did you explore? (Optional)

  7. DylanDylann commented on Mar 28, 2024

    @DylanDylann
    Contributor

    @cubuspl42 The PR is ready for review: #39053

  8. 2 remaining items

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 8, 2024
  10. changed the title [-]Distance- Blank space above waypoints when transitioning between request and confirmation page[/-] [+][HOLD for payment 2024-04-15] Distance- Blank space above waypoints when transitioning between request and confirmation page[/+] on Apr 8, 2024
  11. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-15. 🎊

  13. melvin-bot commented on Apr 15, 2024

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  14. melvin-bot commented on Apr 17, 2024

    @melvin-bot

    @neil-marcellini Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. neil-marcellini commented on Apr 17, 2024

    @neil-marcellini
    Contributor

    No payment needed to fix a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions