You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-04-09] [Wave Collect][QBO] Make it easy to conditionally add or remove routes/screens in WorkspaceSettingsModalStackNavigator #39087
As part of the QBO project, we're adding screens where workspace admins can configure accounting software integration. It's important that only admin users can access these screens.
The current code pattern doesn't allow for conditional access to screens/routes. Therefore, we need to refactor the code associated with the creation of navigators to facilitate the implementation of conditional or protected routes.
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@situchan] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
Activity
melvin-bot commentedon Mar 27, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01959c603423a2c060
melvin-bot commentedon Mar 27, 2024
Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (
Internal)melvin-bot commentedon Mar 27, 2024
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Mar 27, 2024
Current assignee @adelekennedy is eligible for the NewFeature assigner, not assigning anyone new.
9 remaining items
melvin-bot commentedon Apr 2, 2024
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Apr 9, 2024
Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Apr 9, 2024
Payment Summary
Upwork Job
BugZero Checklist (@twisterdotcom)
hayata-suenaga commentedon Apr 10, 2024
If we decide to not to use the pattern of conditional rendering the routes, we might want to undo changes made in this PR.
but for the payment, it's as usual for Situan who reviewed the PR
twisterdotcom commentedon Apr 11, 2024
Okay, just going to pay @situchan $250 here.
twisterdotcom commentedon Apr 11, 2024
Payment Summary:
situchan commentedon May 20, 2024
@twisterdotcom I haven't received payment yet. Can you please check?
And work was done before price drop announcement.
twisterdotcom commentedon May 20, 2024
Whoah you're right, I've no idea where this offer went. Try this now: https://www.upwork.com/nx/wm/offer/102382148
situchan commentedon Oct 17, 2024
@twisterdotcom can you please check this?
twisterdotcom commentedon Oct 18, 2024
I just added a bonus to that payment: https://www.upwork.com/nx/wm/workroom/37321844/overview