Skip to content

[HOLD for payment 2024-04-09] [Wave Collect][QBO] Make it easy to conditionally add or remove routes/screens in WorkspaceSettingsModalStackNavigator #39087

Closed

Description

@hayata-suenaga

As part of the QBO project, we're adding screens where workspace admins can configure accounting software integration. It's important that only admin users can access these screens.

The current code pattern doesn't allow for conditional access to screens/routes. Therefore, we need to refactor the code associated with the creation of navigators to facilitate the implementation of conditional or protected routes.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01959c603423a2c060
  • Upwork Job ID: 1773049719285043200
  • Last Price Increase: 2024-03-27

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 27, 2024
  2. melvin-bot commented on Mar 27, 2024

    @melvin-bot
  3. melvin-bot commented on Mar 27, 2024

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

  4. melvin-bot commented on Mar 27, 2024

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collecton Mar 27, 2024
  6. added
    NewFeatureSomething to build that is a new item.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 27, 2024
  7. melvin-bot commented on Mar 27, 2024

    @melvin-bot

    Current assignee @adelekennedy is eligible for the NewFeature assigner, not assigning anyone new.

  8. 9 remaining items

  9. melvin-bot commented on Apr 2, 2024

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  10. melvin-bot commented on Apr 9, 2024

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  11. melvin-bot commented on Apr 9, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@twisterdotcom)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1773049719285043200/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. hayata-suenaga commented on Apr 10, 2024

    @hayata-suenaga
    ContributorAuthor

    If we decide to not to use the pattern of conditional rendering the routes, we might want to undo changes made in this PR.

    but for the payment, it's as usual for Situan who reviewed the PR

  13. twisterdotcom commented on Apr 11, 2024

    @twisterdotcom
    Contributor

    Okay, just going to pay @situchan $250 here.

  14. twisterdotcom commented on Apr 11, 2024

    @twisterdotcom
    Contributor

    Payment Summary:

  15. moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collecton Apr 11, 2024
  16. situchan commented on May 20, 2024

    @situchan
    Contributor

    @twisterdotcom I haven't received payment yet. Can you please check?
    And work was done before price drop announcement.

  17. twisterdotcom commented on May 20, 2024

    @twisterdotcom
    Contributor

    Whoah you're right, I've no idea where this offer went. Try this now: https://www.upwork.com/nx/wm/offer/102382148

  18. situchan commented on Oct 17, 2024

    @situchan
    Contributor

    And work was done before price drop announcement.

    @twisterdotcom can you please check this?

  19. twisterdotcom commented on Oct 18, 2024

    @twisterdotcom
    Contributor

    I just added a bonus to that payment: https://www.upwork.com/nx/wm/workroom/37321844/overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2InternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions