Skip to content

[HOLD for payment 2024-07-10] [$250] [TS Migration] Investigate and remove usages of EmptyObject #39124

Closed

Description

@mountiny

Follow up issue for TS migration project. Coming from this spreadsheet

Investigate and remove usages of EmptyObject across libs and components (it will be easier now when all files are TS)

Any more details for this one cc @blazejkustra @fabioh8010

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019e9ec8ddc48ac6c7
  • Upwork Job ID: 1780333615910244352
  • Last Price Increase: 2024-04-23
  • Automatic offers:
    • rayane-djouah | Reviewer | 0
    • jsdev2547 | Contributor | 0
    • tienifr | Contributor | 0
    • mkhutornyi | Contributor | 102856727
Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

Activity

  1. changed the title [-][TS Migration] Investigate and remove usages of EmptyObject[/-] [+][HOLD TS migration completion] [TS Migration] Investigate and remove usages of EmptyObject[/+] on Mar 28, 2024
  2. blazejkustra commented on Apr 15, 2024

    @blazejkustra
    Contributor

    Details:
    This is a bigger task that requires a lot of changes in the logic, basically we need to search for all EmptyObject usages in the code and try to remove them, also we should remove some of isEmptyObject usages and {} default values to improve the logic further more.

    ⚠️ A deep understanding of Typescript and how onyx types work is required from anyone taking this one.

  3. changed the title [-][HOLD TS migration completion] [TS Migration] Investigate and remove usages of EmptyObject[/-] [+][TS Migration] Investigate and remove usages of EmptyObject[/+] on Apr 16, 2024
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 16, 2024
  5. changed the title [-][TS Migration] Investigate and remove usages of EmptyObject[/-] [+][$250] [TS Migration] Investigate and remove usages of EmptyObject[/+] on Apr 16, 2024
  6. melvin-bot commented on Apr 16, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 16, 2024
  8. melvin-bot commented on Apr 16, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

  9. 74 remaining items

  10. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-10. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mkhutornyi] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  12. joekaufmanexpensify commented on Jul 8, 2024

    @joekaufmanexpensify
    Contributor

    No checklist needed here for TS migration

  13. joekaufmanexpensify commented on Jul 10, 2024

    @joekaufmanexpensify
    Contributor

    Payment is a bit complex here, as there were two contributors and C+ at various points on this issue. Discussing here.

  14. joekaufmanexpensify commented on Jul 10, 2024

    @joekaufmanexpensify
    Contributor

    We discussed in Slack, and decided to split payment here four-ways between both contributors and both C+, $125 to everyone. This would mean:

    • $125 to jsdev2547 via Upwork for creating their proposal and most of a PR (before they were removed).
    • $125 to @tienifr via Upwork for picking the issue up, creating a new PR and getting it over the line.
    • $125 to @rayane-djouah via Upwork for C+ role of reviewing proposals and reviewing first PR.
    • $125 to @mkhutornyi via Upwork for C+, picking up second PR review and getting it over the line.

    LMK if any Q's on that!

  15. joekaufmanexpensify commented on Jul 10, 2024

    @joekaufmanexpensify
    Contributor

    Issuing payment now!

  16. joekaufmanexpensify commented on Jul 10, 2024

    @joekaufmanexpensify
    Contributor

    All payment issued and contracts closed.

  17. joekaufmanexpensify commented on Jul 10, 2024

    @joekaufmanexpensify
    Contributor

    Upwork job closed.

  18. joekaufmanexpensify commented on Jul 10, 2024

    @joekaufmanexpensify
    Contributor

    All set, thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.TaskTypescript Migration

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions