You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-10] [$250] [TS Migration] Investigate and remove usages of EmptyObject #39124
changed the title [-][TS Migration] Investigate and remove usages of EmptyObject[/-][+][HOLD TS migration completion] [TS Migration] Investigate and remove usages of EmptyObject[/+]on Mar 28, 2024
Details:
This is a bigger task that requires a lot of changes in the logic, basically we need to search for all EmptyObject usages in the code and try to remove them, also we should remove some of isEmptyObject usages and {} default values to improve the logic further more.
⚠️A deep understanding of Typescript and how onyx types work is required from anyone taking this one.
changed the title [-][HOLD TS migration completion] [TS Migration] Investigate and remove usages of EmptyObject[/-][+][TS Migration] Investigate and remove usages of EmptyObject[/+]on Apr 16, 2024
changed the title [-][TS Migration] Investigate and remove usages of EmptyObject[/-][+][$250] [TS Migration] Investigate and remove usages of EmptyObject[/+]on Apr 16, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mkhutornyi] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
[-][TS Migration] Investigate and remove usages of EmptyObject[/-][+][HOLD TS migration completion] [TS Migration] Investigate and remove usages of EmptyObject[/+]blazejkustra commentedon Apr 15, 2024
Details:
This is a bigger task that requires a lot of changes in the logic, basically we need to search for all
EmptyObjectusages in the code and try to remove them, also we should remove some ofisEmptyObjectusages and{}default values to improve the logic further more.[-][HOLD TS migration completion] [TS Migration] Investigate and remove usages of EmptyObject[/-][+][TS Migration] Investigate and remove usages of EmptyObject[/+][-][TS Migration] Investigate and remove usages of EmptyObject[/-][+][$250] [TS Migration] Investigate and remove usages of EmptyObject[/+]melvin-bot commentedon Apr 16, 2024
Job added to Upwork: https://www.upwork.com/jobs/~019e9ec8ddc48ac6c7
melvin-bot commentedon Apr 16, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (
External)74 remaining items
melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
EmptyObjecttype #42851If no regressions arise, payment will be issued on 2024-07-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 3, 2024
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
joekaufmanexpensify commentedon Jul 8, 2024
No checklist needed here for TS migration
joekaufmanexpensify commentedon Jul 10, 2024
Payment is a bit complex here, as there were two contributors and C+ at various points on this issue. Discussing here.
joekaufmanexpensify commentedon Jul 10, 2024
We discussed in Slack, and decided to split payment here four-ways between both contributors and both C+, $125 to everyone. This would mean:
LMK if any Q's on that!
joekaufmanexpensify commentedon Jul 10, 2024
Issuing payment now!
joekaufmanexpensify commentedon Jul 10, 2024
All payment issued and contracts closed.
joekaufmanexpensify commentedon Jul 10, 2024
Upwork job closed.
joekaufmanexpensify commentedon Jul 10, 2024
All set, thanks everyone!