Skip to content

[HOLD for payment 2024-04-25] Android & iOS - Workspace - Workspace is not crossed out when deleted offline #39178

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-internal team

Action Performed:

Precondition:

  • User has at least two workspaces.
  1. Go to staging.new.expensify.com.
  2. Go to Profile > Workspaces.
  3. Go offline.
  4. Delete any workspace.

Expected Result:

The deleted workspace will appear crossed out.

Actual Result:

The deleted workspace is only grayed out and not crossed out.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6430157_1711630838733.Screen_Recording_20240328_205614_New_Expensify.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 28, 2024
  2. melvin-bot commented on Mar 28, 2024

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. github-actions commented on Mar 28, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Mar 28, 2024

    @melvin-bot

    Triggered auto assignment to @grgia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. izarutskaya commented on Mar 28, 2024

    @izarutskaya
    Author

    @joekaufmanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Mar 28, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #wave-control.

  7. izarutskaya commented on Mar 28, 2024

    @izarutskaya
    Author

    Production

    Screen_Recording_20240328_205554_New.Expensify.mp4
  8. grgia commented on Mar 28, 2024

    @grgia
    Contributor
  9. 4 remaining items

  10. Krishna2323 commented on Mar 28, 2024

    @Krishna2323
    Contributor

    @grgia thanks for the ping, taking a look.

  11. joekaufmanexpensify commented on Apr 15, 2024

    @joekaufmanexpensify
    Contributor

    PR on staging

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 18, 2024
  13. changed the title [-]Android & iOS - Workspace - Workspace is not crossed out when deleted offline[/-] [+][HOLD for payment 2024-04-25] Android & iOS - Workspace - Workspace is not crossed out when deleted offline[/+] on Apr 18, 2024
  14. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-25. 🎊

  16. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@grgia] The PR that introduced the bug has been identified. Link to the PR:
    • [@grgia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@grgia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@grgia] Determine if we should create a regression test for this bug.
    • [@grgia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. joekaufmanexpensify commented on Apr 22, 2024

    @joekaufmanexpensify
    Contributor

    This is a regression fix, so IDT we need to do the checklist, nor is any payment due. Closing for now, but LMK if anyone disagrees with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions