You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-04-25] Android & iOS - Workspace - Workspace is not crossed out when deleted offline #39178
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@joekaufmanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
changed the title [-]Android & iOS - Workspace - Workspace is not crossed out when deleted offline[/-][+][HOLD for payment 2024-04-25] Android & iOS - Workspace - Workspace is not crossed out when deleted offline[/+]on Apr 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@grgia] The PR that introduced the bug has been identified. Link to the PR:
[@grgia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@grgia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@grgia] Determine if we should create a regression test for this bug.
[@grgia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Mar 28, 2024
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Mar 28, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 28, 2024
Triggered auto assignment to @grgia (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.izarutskaya commentedon Mar 28, 2024
@joekaufmanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Mar 28, 2024
We think this issue might be related to the #wave-control.
izarutskaya commentedon Mar 28, 2024
Production
Screen_Recording_20240328_205554_New.Expensify.mp4
grgia commentedon Mar 28, 2024
maybe related to
#38454
https://github.com/Expensify/App/pull/38249/files
@Krishna2323
4 remaining items
Krishna2323 commentedon Mar 28, 2024
@grgia thanks for the ping, taking a look.
joekaufmanexpensify commentedon Apr 15, 2024
PR on staging
[-]Android & iOS - Workspace - Workspace is not crossed out when deleted offline[/-][+][HOLD for payment 2024-04-25] Android & iOS - Workspace - Workspace is not crossed out when deleted offline[/+]melvin-bot commentedon Apr 18, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-25. 🎊
melvin-bot commentedon Apr 18, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
joekaufmanexpensify commentedon Apr 22, 2024
This is a regression fix, so IDT we need to do the checklist, nor is any payment due. Closing for now, but LMK if anyone disagrees with that.