Skip to content

[Pay on Wed 24th Nov] Improve IOU flow with step navigation animations #3921

Closed

Description

@JmillsExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

The IOUModal and step PR introduces a multi-step navigation within a single Modal (see video at bottom of this issue).

Expected Result:

We should improve the current navigation with the use of animations when navigating between steps.

Our plan was to take advantage of the imminent react-native-navigation implementation (using Tab.Screen, hiding the TabBar, and disabling swipe), which gives us page animations and allows us to refresh each step without losing the current state. This change was never made, so it might instead be simpler to use a custom animation.

Actual Result:

Multi-step navigation within a single modal

Workaround:

E.cash is still functional with or without this improvement.

Platform:

All platforms.

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.75
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/1127863/124861455-7952e280-df68-11eb-9001-d17b74cf5d62.mov

Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/156712

View all open jobs on Upwork

Activity

  1. MelvinBot commented on Jul 8, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @conorpendergrast (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Jul 8, 2021
  3. JmillsExpensify commented on Jul 8, 2021

    @JmillsExpensify
    ContributorAuthor

    If you're coming from the Upwork posting (https://www.upwork.com/jobs/~01e8cb25843621f42d), please make sure to share your proposal here and a member from our team will evaluate. Thank you!

  4. MelvinBot commented on Jul 8, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @chiragsalian (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  5. parasharrajat commented on Jul 8, 2021

    @parasharrajat
    Member

    What type of animation are you looking here?

  6. JmillsExpensify commented on Jul 8, 2021

    @JmillsExpensify
    ContributorAuthor

    cc @Julesssss since you're online soon and this is coming from your issue in E.com.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 8, 2021
  8. 47 remaining items

  9. kadiealexander commented on Oct 8, 2021

    @kadiealexander
    Contributor

    Please refer to this post for updated information on the n6 hold, we've raised the bonus to $250 for all issues where a PR is created before the N6 hold is lifted.

  10. MelvinBot commented on Oct 29, 2021

    @MelvinBot
    Contributor

    This issue has not been updated in over 15 days. @JmillsExpensify, @chiragsalian, @rdjuric eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  11. Julesssss commented on Nov 17, 2021

    @Julesssss
    Contributor

    @chiragsalian resolved the conflicts and we've retested and merged the PR. Holding for payment.

  12. changed the title [-]Improve IOU flow with step navigation animations[/-] [+][Pay on Wed 24th Nov] Improve IOU flow with step navigation animations[/+] on Nov 17, 2021
  13. MelvinBot commented on Dec 13, 2021

    @MelvinBot
    Contributor

    This issue has not been updated in over 15 days. @JmillsExpensify, @chiragsalian, @rdjuric eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  14. chiragsalian commented on Dec 13, 2021

    @chiragsalian
    Contributor

    Well the code for this is done. The only thing that remained was the payment to @rdjuric.
    @JmillsExpensify will you be handling that? You can close the issue right after.

  15. JmillsExpensify commented on Jan 7, 2022

    @JmillsExpensify
    ContributorAuthor

    Ah I must have missed this one right before heading on for the holidays. Closing out and providing a bonus for the delay on my part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions