You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Pay on Wed 24th Nov] Improve IOU flow with step navigation animations #3921
The IOUModal and step PR introduces a multi-step navigation within a single Modal (see video at bottom of this issue).
Expected Result:
We should improve the current navigation with the use of animations when navigating between steps.
Our plan was to take advantage of the imminent react-native-navigation implementation (using Tab.Screen, hiding the TabBar, and disabling swipe), which gives us page animations and allows us to refresh each step without losing the current state. This change was never made, so it might instead be simpler to use a custom animation.
Actual Result:
Multi-step navigation within a single modal
Workaround:
E.cash is still functional with or without this improvement.
If you're coming from the Upwork posting (https://www.upwork.com/jobs/~01e8cb25843621f42d), please make sure to share your proposal here and a member from our team will evaluate. Thank you!
Please refer to this post for updated information on the n6 hold, we've raised the bonus to $250 for all issues where a PR is created before the N6 hold is lifted.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
changed the title [-]Improve IOU flow with step navigation animations[/-][+][Pay on Wed 24th Nov] Improve IOU flow with step navigation animations[/+]on Nov 17, 2021
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Well the code for this is done. The only thing that remained was the payment to @rdjuric. @JmillsExpensify will you be handling that? You can close the issue right after.
Activity
MelvinBot commentedon Jul 8, 2021
Triggered auto assignment to @conorpendergrast (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.JmillsExpensify commentedon Jul 8, 2021
If you're coming from the Upwork posting (https://www.upwork.com/jobs/~01e8cb25843621f42d), please make sure to share your proposal here and a member from our team will evaluate. Thank you!
MelvinBot commentedon Jul 8, 2021
Triggered auto assignment to @chiragsalian (
Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.parasharrajat commentedon Jul 8, 2021
What type of animation are you looking here?
JmillsExpensify commentedon Jul 8, 2021
cc @Julesssss since you're online soon and this is coming from your issue in E.com.
47 remaining items
kadiealexander commentedon Oct 8, 2021
Please refer to this post for updated information on the
n6 hold, we've raised the bonus to $250 for all issues where a PR is created before the N6 hold is lifted.MelvinBot commentedon Oct 29, 2021
This issue has not been updated in over 15 days. @JmillsExpensify, @chiragsalian, @rdjuric eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Julesssss commentedon Nov 17, 2021
@chiragsalian resolved the conflicts and we've retested and merged the PR. Holding for payment.
[-]Improve IOU flow with step navigation animations[/-][+][Pay on Wed 24th Nov] Improve IOU flow with step navigation animations[/+]MelvinBot commentedon Dec 13, 2021
This issue has not been updated in over 15 days. @JmillsExpensify, @chiragsalian, @rdjuric eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
chiragsalian commentedon Dec 13, 2021
Well the code for this is done. The only thing that remained was the payment to @rdjuric.
@JmillsExpensify will you be handling that? You can close the issue right after.
JmillsExpensify commentedon Jan 7, 2022
Ah I must have missed this one right before heading on for the holidays. Closing out and providing a bonus for the delay on my part.