Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
This is a new E.cash initiative. See expected result.
Expected Result:
-
Create a new file
/PaymentPages/TransferBalancePage.js -
Add a route for the transfer balance page:
ROUTES.SETTINGS_TRANSFER_BALANCE = "settings/payments/transfer-balance" -
Add a "Transfer Balance" button to
PaymentsPage.jsthat links to the new transfer page- Icon:
- We will need to add the transfer icon to the assets/images folder, and then export it in
src/components/Icon/Expensicons.js. - We will then import it in PaymentsPage.js and pass that icon as a param
- We will need to add the transfer icon to the assets/images folder, and then export it in
- OnPress:
- Navigate to the transfer balance page
- PrimaryText: “Transfer Balance”
- shouldShowRightArrow: True
- The button will only be shown if there is a balance above $0
- Icon:
-
Add the
<currentBalance>component to the top -
Add 2
<menuItem>components for instant/slow transfer- Instant:
- Icon: LightningBolt (new)
- PrimaryText: Instant
- SecondaryText: 1.5% fee ($0.25 minimum)
- onPress: () => this.setState({transferType: Instant})
- ACH:
- Icon: Bank
- PrimaryText: 1-3 Business Days
- SecondaryText: No Fee
- onPress: () =. this.setState({transferType: ACH})
- When the state changes, the item that was clicked will show a different border and icon color
- Instant:
-
Create the "Which Account" section
- This should be a
<MenuItem> - For an example of the rendering take a look at
PaymentMethodList.js - The initial account should be the account defined in the onyx prop
USER_WALLET.linkedBankAccount - The onPress for the MenuItem will navigate to
ChooseTransferAccountPage
- This should be a
-
Create a new page
ChooseTransferAccountPage.js(screenshot 3)- The route for this page will be
ROUTES.SETTINGS_PAYMENTS_CHOOSE_TRANSFER_ACCOUNT = “settings/payments/choose-transfer-Account” - The page will display a
<PaymentMethodList>- When a method is selected, we will route back to
TransferBalancePagewith the account type and ID - The selected method should be displayed in the choose account section
- When a method is selected, we will route back to
- The route for this page will be
-
Create the "Transfer" button
- This should be a
<PressableOpacity> - The
onPressshould:- Call PaymentMethods.TransferWalletBalance() (described below)
- Display a
<FullScreenLoadingIndicator> - When the API command is complete
- Hide the loading indicator
- Display a success modal (The far right screenshot) that on submit will reroute to PaymentsPage.js
- This will be created by using the default react native component, similar to
confirmModal.js
- This should be a
-
Create a new method in
PaymentMethods.jscalledTransferWalletBalance()- This should call a new method in
API.jscalledTransferWalletBalance()- This will call the API command
TransferWalletBalance(no parameters necessary)
- This will call the API command
- Once the API call comes back positive this method should set
USER_WALLET.balance = 0in Onyx
- This should call a new method in
Progress
Per this comment we are breaking this down to smaller pieces.
-
Do a simple PR to scaffold out some of the little changes first and add all the assets, consts, pages, etc (PR)
- Add consts
- Add Routes
- Add blank pages for the new routes we are adding
- Translations
- API.js change
- Move payment methods list building logic into PaymentUtils without modifying the original logic and use in PaymentMethodList.
-
Create the TransferBalancePage and have the account select feature disabled for now - we can test with just the default account and see that transfers can be initiated, errors handled, etc. (PR)
-
Create a new component that wraps AddPaymentMethodMenu (without modifying this component too much) and call it “AddBalanceTransferAccountButton”
-
Create a version of the PaymentMethodList that is selectable. It should not duplicate the logic, but wrap PaymentMethodList.
-
Build out the ChooseTransferBalanceAccount page and hook it up to TransferBalancePage so we can select an account.
Platform:
All platforms
Version Number: N/A
Logs: N/A
Notes/Photos/Videos: Please ask any questions in this issue.
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/169395

Activity
MelvinBot commentedon Jul 8, 2021
Triggered auto assignment to @davidcardoza (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.[-][P2P in E.cash] Add the Transfer Balance Page[/-][+]Add the Transfer Balance Page[/+]JmillsExpensify commentedon Jul 8, 2021
If you're coming from our Upwork posting (https://www.upwork.com/jobs/~01081fb3ff015abc6c), a heads up that we will prioritizing contributors that we have been actively working with. Thank you!
MelvinBot commentedon Jul 8, 2021
Triggered auto assignment to @tgolen (
Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.Burhanuddin971 commentedon Jul 8, 2021
I've submitted the proposal on Upwork. Please do check
118 remaining items
parasharrajat commentedon Jan 25, 2022
Submitted the PR #7373. Sorry for the delay in this task. There were many bottlenecks but I am happy it is done now.
Apart from it, I wanted to discuss the task compensation. First, the job is closed on Upwork. so a new job might be needed. The previous job was priced at $375. But that value does not satisfy the work done for this task.
There are a couple of reasons I feel that the budget should be increased.
Apart from it, the first PR went through N6-Hold and Company Offsite Hold.
stitesExpensify commentedon Jan 25, 2022
Thanks for all of the work @parasharrajat !
@JmillsExpensify I definitely agree that the compensation should be increased 👍
marcaaron commentedon Jan 25, 2022
+1 to increase for this. This one needed some extra love and attention, scope increased a bit, and took a fairly long time to complete at no fault of yours. Thanks for your patience with us and flexibility to do things the correct way @parasharrajat.
parasharrajat commentedon Jan 25, 2022
Thanks for your guidance as well. I never give up a task but there was a moment when I thought It will never complete.
JmillsExpensify commentedon Jan 26, 2022
Awesome, happy to process the payment and increase. I'm defaulting to doubling the job, though if that's not right then someone on this issue can chime in (or reach out) and I can process the right amount.
parasharrajat commentedon Jan 26, 2022
@JmillsExpensify Doubling works for me as far as the holding bonuses are counted separately.
parasharrajat commentedon Jan 26, 2022
@JmillsExpensify I saw that you released a bonus amount on the old contract. But I canceled that contract a month ago for some reason and no payment was released to me. Thus, I have to refund that bonus back to you to manage my finances. Sorry for the inconvenience. Please let me know if you have any questions otherwise, I will refund that bonus.
Could you please create a new fresh job and I would like to apply and receive payment through that.
This is the breakdown of the payment which I am aware of.
JmillsExpensify commentedon Jan 27, 2022
Ok thanks! Yes, that makes sense. I created a fresh job here: https://www.upwork.com/jobs/~0164b1f1886c372bf6
Wp32793 commentedon Jan 28, 2022
JmillsExpensify commentedon Feb 1, 2022
I processed the payment, so I'm going to close the issue. Don't hesitate to reach out here or via Slack if I can help with anything else!
[-][HOLD for payment 2022-01-25] Add the Transfer Balance Page[/-][+][HOLD for payment 2022-02-08] [HOLD for payment 2022-01-25] Add the Transfer Balance Page[/+]botify commentedon Feb 1, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.33-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-02-08. 🎊