Skip to content

[HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Task - Not here page shows up when opening room link under header subtitle in deleted task #39251

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to a room.
  3. Create a task.
  4. Leave the room.
  5. Go to task report.
  6. Click room link under header subtitle.
  7. Note that the room opens without issue.
  8. Delete the task.
  9. Click room link under header subtitle.

Expected Result:

The room will open without issue.

Actual Result:

Not here page shows up when opening room link under header subtitle in deleted task report.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6431595_1711719925376.thread_task.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 29, 2024
  2. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. github-actions commented on Mar 29, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Mar 29, 2024

    @izarutskaya
    Author

    @sakluger I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Mar 29, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #vip-vsb.

  7. izarutskaya commented on Mar 29, 2024

    @izarutskaya
    Author

    Production

    bandicam.2024-03-29.16-15-38-015.mp4
  8. gijoe0295 commented on Mar 29, 2024

    @gijoe0295
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Not here page shows up when opening room link under header subtitle in deleted task report.

    What is the root cause of that problem?

    Regression from #38722.

    When click the room name, we navigate to the parent report action in the room:

    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(parentReportID, parentReportActionID));

    Unfortunately, when we delete the task, the task report action is no longer there, leading to Not found page.

    What changes do you think we should make in order to solve the problem?

    Before navigating, we should check if that parent report action is deleted by isDeletedAction. In order to do this, we need to subscribe to parentReportAction in Onyx.

    What alternative solutions did you explore? (Optional)

    NA

  9. 14 remaining items

  10. changed the title [-]Task - Not here page shows up when opening room link under header subtitle in deleted task[/-] [+][HOLD for payment 2024-04-09] Task - Not here page shows up when opening room link under header subtitle in deleted task[/+] on Apr 2, 2024
  11. melvin-bot commented on Apr 2, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Apr 2, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-09. 🎊

  13. melvin-bot commented on Apr 2, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@deetergp] The PR that introduced the bug has been identified. Link to the PR:
    • [@deetergp] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@deetergp] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@deetergp] Determine if we should create a regression test for this bug.
    • [@deetergp] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. rayane-d commented on Apr 4, 2024

    @rayane-d
    Contributor

    We can close this one

  15. changed the title [-][HOLD for payment 2024-04-09] Task - Not here page shows up when opening room link under header subtitle in deleted task[/-] [+][HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Task - Not here page shows up when opening room link under header subtitle in deleted task[/+] on Apr 8, 2024
  16. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-15. 🎊

  17. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@deetergp] The PR that introduced the bug has been identified. Link to the PR:
    • [@deetergp] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@deetergp] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@deetergp] Determine if we should create a regression test for this bug.
    • [@deetergp] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  18. sakluger commented on Apr 9, 2024

    @sakluger
    Contributor

    No payment needed since it was just a revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions