Skip to content

[Hold for payment 2024-04-29] [$500] Video - Console error shows up when playing video #39253

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any chat.
  3. Upload a video.
  4. Play the video.

Expected Result:

No console error will show up when playing the video.

Actual Result:

Console error shows up when playing the video.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6431599_1711719930994.console_error_play_vid.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cc61ba1811650dd7
  • Upwork Job ID: 1773756452718587904
  • Last Price Increase: 2024-03-29
Issue OwnerCurrent Issue Owner: @rushatgabhane

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 29, 2024
  2. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. github-actions commented on Mar 29, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Mar 29, 2024

    @izarutskaya
    Author

    @garrettmknight I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Mar 29, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #vip-vsb.

  7. garrettmknight commented on Mar 29, 2024

    @garrettmknight
    Contributor

    I don't think this needs to be a deploy blocker since it's just a JS error and the video still plays.

  8. 37 remaining items

  9. changed the title [-][$500] Video - Console error shows up when playing video[/-] [+][Hold for payment 2024-04-29] [$500] Video - Console error shows up when playing video[/+] on Apr 29, 2024
  10. garrettmknight commented on Apr 29, 2024

    @garrettmknight
    Contributor

    Payment summary:

    @nkdengineer offer is here

  11. JmillsExpensify commented on Apr 30, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @rushatgabhane

  12. nkdengineer commented on May 6, 2024

    @nkdengineer
    Contributor

    @nkdengineer offer is here

    @garrettmknight I accepted it 🙇

  13. garrettmknight commented on May 9, 2024

    @garrettmknight
    Contributor

    All paid up - @rushatgabhane can you complete the checklist?

  14. rushatgabhane commented on May 13, 2024

    @rushatgabhane
    Member
    1. The PR that introduced the bug has been identified. Link to the PR: Video player #30829

    2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30829/files#r1598185709

    3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

    4. Determine if we should create a regression test for this bug. - Yes

    5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again
      1. Go to any chat
      2. Send a video
      3. Click play
      4. Verify that no console error shows up

  15. garrettmknight commented on May 13, 2024

    @garrettmknight
    Contributor

    All set here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions