You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Hold for payment 2024-04-29] [$500] Video - Console error shows up when playing video #39253
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@garrettmknight I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
changed the title [-][$500] Video - Console error shows up when playing video[/-][+][Hold for payment 2024-04-29] [$500] Video - Console error shows up when playing video[/+]on Apr 29, 2024
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. - Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again
1. Go to any chat
2. Send a video
3. Click play
4. Verify that no console error shows up
Activity
melvin-bot commentedon Mar 29, 2024
Triggered auto assignment to @luacmartins (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 29, 2024
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Mar 29, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Mar 29, 2024
@garrettmknight I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Mar 29, 2024
We think this issue might be related to the #vip-vsb.
garrettmknight commentedon Mar 29, 2024
I don't think this needs to be a deploy blocker since it's just a JS error and the video still plays.
37 remaining items
[-][$500] Video - Console error shows up when playing video[/-][+][Hold for payment 2024-04-29] [$500] Video - Console error shows up when playing video[/+]garrettmknight commentedon Apr 29, 2024
Payment summary:
@nkdengineer offer is here
JmillsExpensify commentedon Apr 30, 2024
$500 approved for @rushatgabhane
nkdengineer commentedon May 6, 2024
@garrettmknight I accepted it 🙇
garrettmknight commentedon May 9, 2024
All paid up - @rushatgabhane can you complete the checklist?
rushatgabhane commentedon May 13, 2024
The PR that introduced the bug has been identified. Link to the PR: Video player #30829
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30829/files#r1598185709
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. - Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again
1. Go to any chat
2. Send a video
3. Click play
4. Verify that no console error shows up
garrettmknight commentedon May 13, 2024
All set here