Skip to content

Taxes - App does not allow user to enter any digit after dot when there are 6 zeros before it #39257

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Profile > Workspaces > Collect workspace
  3. Go to Taxes
  4. Click Add rate > Value
  5. Enter 6 zeros
  6. Add a dot
  7. Add any number

Expected Result:

App will allow user to enter any digit since there are only 6 digits in the input

Actual Result:

App does not allow user to enter any digit after the dot when there are 6 zeros before it

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6431601_1711719933898.tax_input.mp4

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Mar 29, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. lanitochka17 commented on Mar 29, 2024

    @lanitochka17
    Author

    @rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Mar 29, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  5. ZhenjaHorbach commented on Mar 29, 2024

    @ZhenjaHorbach
    Contributor

    Looks like regression from this PR

    #38733

  6. rlinoz commented on Mar 29, 2024

    @rlinoz
    Contributor

    Since every other input works fine, I don't we should hold this as a blocker, so removing demoting it.

  7. removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 29, 2024
  8. rlinoz commented on Mar 29, 2024

    @rlinoz
    Contributor

    Also, I think the bug is that we allow more than four 0s since we limit the field for every other input to 4 characters.

  9. added and removed on Mar 29, 2024
  10. rlinoz commented on Apr 1, 2024

    @rlinoz
    Contributor

    I don't think this is worth fixing, the field only has a problem if we add more than 4 leading zeroes before the decimal symbol, so I am closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions