You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Taxes - App does not allow user to enter any digit after dot when there are 6 zeros before it #39257
Version Number: 1.4.58-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to Profile > Workspaces > Collect workspace
Go to Taxes
Click Add rate > Value
Enter 6 zeros
Add a dot
Add any number
Expected Result:
App will allow user to enter any digit since there are only 6 digits in the input
Actual Result:
App does not allow user to enter any digit after the dot when there are 6 zeros before it
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Activity
melvin-bot commentedon Mar 29, 2024
Triggered auto assignment to @rlinoz (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Mar 29, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Mar 29, 2024
@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Mar 29, 2024
We think that this bug might be related to #vip-vsp
ZhenjaHorbach commentedon Mar 29, 2024
Looks like regression from this PR
#38733
rlinoz commentedon Mar 29, 2024
Since every other input works fine, I don't we should hold this as a blocker, so removing demoting it.
rlinoz commentedon Mar 29, 2024
Also, I think the bug is that we allow more than four 0s since we limit the field for every other input to 4 characters.
rlinoz commentedon Apr 1, 2024
I don't think this is worth fixing, the field only has a problem if we add more than 4 leading zeroes before the decimal symbol, so I am closing it.