Skip to content

Don't allow upload of large attachments [hold for payment on August 5th] #3926

Closed

Description

@rushatgabhane

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


I'm assuming API allows max attachment size of 100 MB. Please correct me if I'm wrong.

Action Performed:

  1. Login to E.cash
  2. Click add attachment.
  3. Select a file larger than 100 MB, and send it.

Expected Result:

Should display a message like "Attachment is larger than 100 MB"
and not allow upload of the attachment.

Actual Result:

The attachment is allowed to upload even though the API doesn't allow uploads larger than 100 MB.
And a forever spinner gets displayed.

Workaround:

N.A.

Platform:

Where is this issue occurring?

Web ✔️
iOS ✔️
Android ✔️
Desktop App ✔️
Mobile Web ✔️

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

Activity

  1. MelvinBot commented on Jul 8, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @bfitzexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Jul 8, 2021
  3. rushatgabhane commented on Jul 8, 2021

    @rushatgabhane
    MemberAuthor

    Proposal

    In components/AttachmentModal

    For attachments larger than 100 MB,
    show the message "Attachment is larger than 100 MB limit", and disable the send button.

    English and Spanish message will be added, and size limit will be set in CONST.js

  4. MelvinBot commented on Jul 26, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  5. removed their assignment
    on Jul 26, 2021
  6. yuwenmemon commented on Jul 26, 2021

    @yuwenmemon
    Contributor

    I'm curious how we picture this error message to show? I don't think we should even render the preview and disable the upload button here. Since a large file would probably be cumbersome to render anyway:
    Screen Shot 2021-07-26 at 2 27 35 PM

    We should probably just flash a separate, solo error message

  7. yuwenmemon commented on Jul 26, 2021

    @yuwenmemon
    Contributor

    Code where this happens:

    onChange={(e) => {
    const file = e.target.files[0];
    if (file) {
    file.uri = URL.createObjectURL(file);
    this.onPicked(file);
    }
    // Cleanup after selecting a file to start from a fresh state
    this.fileInput.value = null;

  8. yuwenmemon commented on Jul 26, 2021

    @yuwenmemon
    Contributor

    Spanish translation: El documento adjunto supera el límite de 100 MB

  9. quinthar commented on Jul 26, 2021

    @quinthar
    Contributor
  10. 21 remaining items

  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 29, 2021
  12. MelvinBot commented on Jul 29, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @NikkiWines (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  13. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 29, 2021
  14. yuwenmemon commented on Jul 29, 2021

    @yuwenmemon
    Contributor

    I believe @rushatgabhane is working on this? (And it was already merged?)

  15. kadiealexander commented on Jul 29, 2021

    @kadiealexander
    Contributor

    Yeah, it moved really quickly. Was just getting the Upwork post up to arrange payment for @rushatgabhane :)

  16. rushatgabhane commented on Jul 29, 2021

    @rushatgabhane
    MemberAuthor

    I believe @rushatgabhane is working on this? (And it was already merged?)

    Yes :)

  17. kadiealexander commented on Aug 2, 2021

    @kadiealexander
    Contributor

    Issue #4356 must be resolved.

  18. rushatgabhane commented on Aug 3, 2021

    @rushatgabhane
    MemberAuthor

    @kadiealexander resolved and closed!

  19. kadiealexander commented on Aug 3, 2021

    @kadiealexander
    Contributor

    Thanks @rushatgabhane! The original PR was merged 5 days ago, so will process payment in 2 more days. :)

  20. changed the title [-]Don't allow upload of large attachments.[/-] [+]Don't allow upload of large attachments [hold for payment on August 5th][/+] on Aug 3, 2021
  21. kadiealexander commented on Aug 5, 2021

    @kadiealexander
    Contributor

    Paid with a bonus for finding the issue! Thanks @rushatgabhane 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions