You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Don't allow upload of large attachments [hold for payment on August 5th] #3926
I'm curious how we picture this error message to show? I don't think we should even render the preview and disable the upload button here. Since a large file would probably be cumbersome to render anyway:
We should probably just flash a separate, solo error message
changed the title [-]Don't allow upload of large attachments.[/-][+]Don't allow upload of large attachments [hold for payment on August 5th][/+]on Aug 3, 2021
Activity
MelvinBot commentedon Jul 8, 2021
Triggered auto assignment to @bfitzexpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.rushatgabhane commentedon Jul 8, 2021
Proposal
In components/AttachmentModal
For attachments larger than 100 MB,
show the message "Attachment is larger than 100 MB limit", and disable the send button.
English and Spanish message will be added, and size limit will be set in CONST.js
MelvinBot commentedon Jul 26, 2021
Triggered auto assignment to @yuwenmemon (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.yuwenmemon commentedon Jul 26, 2021
I'm curious how we picture this error message to show? I don't think we should even render the preview and disable the upload button here. Since a large file would probably be cumbersome to render anyway:

We should probably just flash a separate, solo error message
yuwenmemon commentedon Jul 26, 2021
Code where this happens:
App/src/components/AttachmentPicker/index.js
Lines 19 to 28 in beb40ee
yuwenmemon commentedon Jul 26, 2021
Spanish translation:
El documento adjunto supera el límite de 100 MBquinthar commentedon Jul 26, 2021
21 remaining items
MelvinBot commentedon Jul 29, 2021
Triggered auto assignment to @NikkiWines (
Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.yuwenmemon commentedon Jul 29, 2021
I believe @rushatgabhane is working on this? (And it was already merged?)
kadiealexander commentedon Jul 29, 2021
Yeah, it moved really quickly. Was just getting the Upwork post up to arrange payment for @rushatgabhane :)
rushatgabhane commentedon Jul 29, 2021
Yes :)
kadiealexander commentedon Aug 2, 2021
Issue #4356 must be resolved.
rushatgabhane commentedon Aug 3, 2021
@kadiealexander resolved and closed!
kadiealexander commentedon Aug 3, 2021
Thanks @rushatgabhane! The original PR was merged 5 days ago, so will process payment in 2 more days. :)
[-]Don't allow upload of large attachments.[/-][+]Don't allow upload of large attachments [hold for payment on August 5th][/+]kadiealexander commentedon Aug 5, 2021
Paid with a bonus for finding the issue! Thanks @rushatgabhane 😁