Skip to content

Web - Chat - Console error shows up when creating a new line on italic mark down #39265

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58.0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

1.Go to staging.new.expensify.com/
2.Go to any chat
3.Enter _ text _ (without space)
4.Move the cursor to before the second _
5.Create a new line

Expected Result:

No console error

Actual Result:

The cursor moves to the beginning of the text. The new line is only revealed when pressing down key on keyboard. Console error also shows up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

20240329_233454.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 29, 2024
  2. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. github-actions commented on Mar 29, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Mar 29, 2024

    @m-natarajan
    Author

    We think this bug might be related to #vip-vsb

  6. m-natarajan commented on Mar 29, 2024

    @m-natarajan
    Author

    @anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. 6 remaining items

  8. anmurali commented on Apr 9, 2024

    @anmurali

    This is the exception. @thienlnam is this something a contributor can fix or do we need to take it internal? I am not totally sure.

    cursorUtils.js:54 Uncaught TypeError: Failed to execute 'setStart' on 'Range': parameter 1 is not of type 'Node'.
        at c (cursorUtils.js:54:19)
        at p (parserUtils.js:156:5)
        at m (parserUtils.js:183:9)
        at MarkdownTextInput.web.js:147:24
        at MarkdownTextInput.web.js:236:16
        at Object.De (react-dom.production.min.js:54:317)
        at Be (react-dom.production.min.js:54:471)
        at react-dom.production.min.js:55:35
        at Fr (react-dom.production.min.js:105:68)
        at qr (react-dom.production.min.js:106:380)
    
  9. thienlnam commented on Apr 9, 2024

    @thienlnam
    Contributor

    This can be fixed externally, but might require changes in react-native-live-markdown repository. @BartoszGrajdek Is this something you're interested in taking, or do you want us to take it external here?

  10. melvin-bot commented on Apr 12, 2024

    @melvin-bot

    @anmurali @thienlnam this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  11. thienlnam commented on Apr 16, 2024

    @thienlnam
    Contributor
  12. anmurali commented on Apr 30, 2024

    @anmurali

    Brought this to slack here

  13. thienlnam commented on May 8, 2024

    @thienlnam
    Contributor

    This appears to be resolved, I can't reproduce it anymore

    Screen.Recording.2024-05-08.at.12.25.34.PM.mov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions