Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.58-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+omci10@applause.expensifail.com
Issue reported by: Applause -Internal Team
Action Performed:
Precondition: user should be Signed In
- Open https://staging.new.expensify.com/
- Click on FAB > Request money
- Select Manual tab
- Write any amount and click on Next button
- Click on a single contact
- Click on back button
- Click on the "Split" button for the same contact from step 5
Expected Result:
Selected contact should stick to the top and marked with a green checkmark when user clicked on a "Split" button for a single contact
Actual Result:
Nothing happened when user clicked on "Split" button. The split button for the single contact unresponsive on clicks
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Mar 30, 2024
Triggered auto assignment to @iwiznia (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Mar 30, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nexarvo commentedon Apr 1, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Split btn for single contact became inactive when returned from final review
What is the root cause of that problem?
When we select single participant it becomes an
iouType = 'request'. But when we go back this participant is already selected in the onyx so when we hit split for the same participant it tries to save same data in onyx here:App/src/libs/actions/IOU.ts
Lines 398 to 401 in 99cc0b6
And hence nothing changes and the tick circle does not re-render. hence we don't see the participant as selected but actually it is selected.
What changes do you think we should make in order to solve the problem?
When we go back from participant confirmation page we can reset the participant onyx data for type request so that when we select split on the same participant, the data is saved in onyx and hence it will re-render the list item.
App/src/pages/iou/request/step/IOURequestStepConfirmation.js
Lines 166 to 178 in 99cc0b6
We need to pass iouType to the participant object so that it differs between request and split iouType. We need to do change in addSingleParticipant like:
{ ..._.pick(option, 'accountID', 'login', 'isPolicyExpenseChat', 'reportID', 'searchText'), selected: true, + iouType: iouType },and in addParticipantToSelection like:
{ accountID: option.accountID, login: option.login, isPolicyExpenseChat: option.isPolicyExpenseChat, reportID: option.reportID, selected: true, searchText: option.searchText, + iouType: iouType === CONST.IOU.TYPE.REQUEST ? CONST.IOU.TYPE.SPLIT : iouType },What alternative solutions did you explore? (Optional)
Result
033e2d49-aa23-4910-a66f-55fa648fac2b.mp4
marcaaron commentedon Apr 1, 2024
Do you know what PR caused the regression @nexarvo?
iwiznia commentedon Apr 1, 2024
Discussing alternatives here
24 remaining items
[-][HOLD for payment 2024-04-09] IOU - Split btn for single contact became inactive when returned from final review[/-][+][HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] IOU - Split btn for single contact became inactive when returned from final review[/+]melvin-bot commentedon Apr 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-15. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 8, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
sakluger commentedon Apr 9, 2024
I'm a little confused and have a few questions regarding this issue:
sakluger commentedon Apr 12, 2024
Asked those questions in Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1712951143397419
nexarvo commentedon Apr 12, 2024
@sakluger this issue fixed a deploy blocker and there is no regression reported for this issue. Also, creating Upwork job failed when it was made external. I think this will be a $500 as it was assigned and made external before we made standard as $250.
alitoshmatov commentedon Apr 13, 2024
This was handled without my involvement, so no payment for me
sakluger commentedon Apr 15, 2024
Thank you @nexarvo! I've sent you an offer via Upwork here: https://www.upwork.com/nx/wm/offer/101873610.
melvin-bot commentedon Apr 15, 2024
Payment Summary
Upwork Job
ROLE: @alitoshmatov paid $(AMOUNT) via Upwork (LINK)BugZero Checklist (@sakluger)
sakluger commentedon Apr 15, 2024
All paid, thanks everyone!