Skip to content

[HOLD for payment 2024-06-20] [$500] [Held requests] No confirmation prompt when approving held request via the report preview #39335

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #33124

Action Performed:

Precondition:

  • Admin and employee are in the Collect workspace
  1. Go to staging.new.expensify.com
  2. [Employee] Request money from the workspace chat
  3. [Employee] Go to transaction thread, select Hold request and hold the request
  4. [Admin] Go to expense report with the employee
  5. [Admin] Click Approve button
  6. Note that it shows the prompt to approve the held request
  7. [Admin] Return to the main workspace chat with employee
  8. [Admin] Click Approve
  9. Note that there is no prompt to approve the held request
  10. Repeat Step 4 to 9 with Pay with Expensify button in both expense report and main chat

Expected Result:

When clicking on the approve button in expense report (Step 4) and main chat (Step 7), there will be a confirmation prompt to approve the held request

Actual Result:

When approving the held request from the main chat, there is no confirmation prompt. The same goes for Pay with Expensify button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6433337_1711892581287.20240331_213437.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01db46b9f151c17d73
  • Upwork Job ID: 1774864170413936640
  • Last Price Increase: 2024-05-28
  • Automatic offers:
    • DylanDylann | Contributor | 102499792
    • nkdengineer | Contributor | 102527527
Issue OwnerCurrent Issue Owner: @slafortune

Activity

  1. github-actions commented on Mar 31, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Mar 31, 2024

    @melvin-bot

    Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. lanitochka17 commented on Mar 31, 2024

    @lanitochka17
    Author

    @bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Mar 31, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-collect - Release 1

  5. bondydaa commented on Apr 1, 2024

    @bondydaa
    Contributor

    digging into this now

  6. bondydaa commented on Apr 1, 2024

    @bondydaa
    Contributor

    I think it coming from this PR #33124 but it's not immediately clear to me why, looking further.

  7. bondydaa commented on Apr 1, 2024

    @bondydaa
    Contributor

    oh i missed the exact case here, it's that clicking approve in the reportPreview doesn't trigger the model. I thought it was that when you click the same approve button twice it didn't re-trigger the confirmation model 🤦 .

  8. bondydaa commented on Apr 1, 2024

    @bondydaa
    Contributor

    I've asked for confirmation here #31345 (comment)

    not sure this actually needs to be a blocker or not, this case might not have been scoped out in the original GH so it could have just been an oversight.

  9. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 1, 2024
  10. robertjchen commented on Apr 1, 2024

    @robertjchen
    Contributor

    Not a blocker, but definitely should be addressed!

  11. 129 remaining items

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 13, 2024
  13. changed the title [-][$500] [Held requests] No confirmation prompt when approving held request via the report preview[/-] [+][HOLD for payment 2024-06-20] [$500] [Held requests] No confirmation prompt when approving held request via the report preview[/+] on Jun 13, 2024
  14. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-20. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  17. DylanDylann commented on Jun 19, 2024

    @DylanDylann
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
    [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
    [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
    [@DylanDylann] Determine if we should create a regression test for this bug. Yes
    [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition: Workspace enabled approval

    1. Go to the WS chat
    2. Create two expenses
    3. Open the transaction thread report of one expense and hold the request
    4. Submit the expense
    5. As an approver, open WS chat and click on approve in the report preview
    6. Verify that confirmation prompt appears

    Do we agree 👍 or 👎

  18. slafortune commented on Jun 20, 2024

    @slafortune
    Contributor

    @DylanDylann Paid via Upworks ✅
    @nkdengineer Paid via Upworks ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions