You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-20] [$500] [Held requests] No confirmation prompt when approving held request via the report preview #39335
Version Number: 1.4.58-4 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
oh i missed the exact case here, it's that clicking approve in the reportPreview doesn't trigger the model. I thought it was that when you click the same approve button twice it didn't re-trigger the confirmation model 🤦 .
not sure this actually needs to be a blocker or not, this case might not have been scoped out in the original GH so it could have just been an oversight.
changed the title [-][$500] [Held requests] No confirmation prompt when approving held request via the report preview[/-][+][HOLD for payment 2024-06-20] [$500] [Held requests] No confirmation prompt when approving held request via the report preview[/+]on Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition: Workspace enabled approval
Go to the WS chat
Create two expenses
Open the transaction thread report of one expense and hold the request
Submit the expense
As an approver, open WS chat and click on approve in the report preview
Activity
github-actions commentedon Mar 31, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 31, 2024
Triggered auto assignment to @bondydaa (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Mar 31, 2024
@bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Mar 31, 2024
We think that this bug might be related to #wave-collect - Release 1
bondydaa commentedon Apr 1, 2024
digging into this now
bondydaa commentedon Apr 1, 2024
I think it coming from this PR #33124 but it's not immediately clear to me why, looking further.
bondydaa commentedon Apr 1, 2024
oh i missed the exact case here, it's that clicking approve in the reportPreview doesn't trigger the model. I thought it was that when you click the same approve button twice it didn't re-trigger the confirmation model 🤦 .
bondydaa commentedon Apr 1, 2024
I've asked for confirmation here #31345 (comment)
not sure this actually needs to be a blocker or not, this case might not have been scoped out in the original GH so it could have just been an oversight.
robertjchen commentedon Apr 1, 2024
Not a blocker, but definitely should be addressed!
129 remaining items
[-][$500] [Held requests] No confirmation prompt when approving held request via the report preview[/-][+][HOLD for payment 2024-06-20] [$500] [Held requests] No confirmation prompt when approving held request via the report preview[/+]melvin-bot commentedon Jun 13, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 13, 2024
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
DylanDylann commentedon Jun 19, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition: Workspace enabled approval
Do we agree 👍 or 👎
slafortune commentedon Jun 20, 2024
@DylanDylann Paid via Upworks ✅
@nkdengineer Paid via Upworks ✅