Skip to content

[HOLD on #378314][$500] [Held requests] Request on hold becomes unheld when approving only unheld request #39338

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #33124

Action Performed:

Precondition:

  • Admin and employee are in the Collect workspace
  1. [Employee] Request money from the workspace chat
  2. [Employee] Create two money requests
  3. [Employee] Hold one of the requests and leave the other one unheld
  4. [Admin] Go to expense report
  5. [Admin] Click Approve button
  6. [Admin] Approve the unheld request

Expected Result:

The request on hold will be moved to a new report

Actual Result:

Request on hold becomes unheld when approving only unheld request

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6433343_1711893426393.20240331_215154.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d6a3e193d64c10a4
  • Upwork Job ID: 1775018433509507072
  • Last Price Increase: 2024-04-09

Activity

  1. melvin-bot commented on Mar 31, 2024

    @melvin-bot

    Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Mar 31, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. lanitochka17 commented on Mar 31, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-collect - Release 1

  4. lanitochka17 commented on Mar 31, 2024

    @lanitochka17
    Author

    @NikkiWines FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. NikkiWines commented on Apr 2, 2024

    @NikkiWines
    Contributor

    This definitely looks like a regression / unhandled case from #33124. I've been trying to reproduce locally but the behavior is pretty buggy on main right now (crashing when holding an expense, approving the full total and not the held amount, paying doesn't work because the "The requested amount has changed") so it's hard to see what's causing this particular staging behavior

    Pinged @robertjchen since he's got context on the original PR and might be able to lend some insight here

  6. NikkiWines commented on Apr 2, 2024

    @NikkiWines
    Contributor

    Looks like - at least on dev - when approving the report, it's the optimisticIOUReportData from here that is overwriting the amount with the full (held + non-held) amount, even though the amount is correctly being set in optimisticApprovedReportAction here.

  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 2, 2024
  8. robertjchen commented on Apr 2, 2024

    @robertjchen
    Contributor

    Thanks for the report! Definitely related to the changes there: #33124 and we'll be addressing it. Not a deploy blocker per the sentiments here

  9. 40 remaining items

  10. trjExpensify commented on Apr 25, 2024

    @trjExpensify
    Contributor

    Hit prod two days ago, closing!

  11. nkdengineer commented on May 6, 2024

    @nkdengineer
    Contributor

    @NikkiWines @trjExpensify We have this bug #41652 here this is the part of this issue since we don't implement the optimistic data when we approve partial. Can you please take a look and re-open this issue.

  12. NikkiWines commented on May 8, 2024

    @NikkiWines
    Contributor

    @NikkiWines @trjExpensify We have this bug #41652 here this is the part of this issue since we don't implement the optimistic data when we approve partial. Can you please take a look and re-open this issue.

    Been focused on some other urgent issues but I will look into this during the week. From a quick glance it looks like there's some activity in the linked issue for resolving the issue as well. Re-opening for now so it doesn't fall off my radar.

  13. trjExpensify commented on May 8, 2024

    @trjExpensify
    Contributor

    I think we can use the other issue for this follow-up. @nkdengineer I've assigned you for the C+ review on that.

  14. NikkiWines commented on May 8, 2024

    @NikkiWines
    Contributor

    Sounds good, re-closing this then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions