You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD on #378314][$500] [Held requests] Request on hold becomes unheld when approving only unheld request #39338
Version Number: 1.4.58-4 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@NikkiWines FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
This definitely looks like a regression / unhandled case from #33124. I've been trying to reproduce locally but the behavior is pretty buggy on main right now (crashing when holding an expense, approving the full total and not the held amount, paying doesn't work because the "The requested amount has changed") so it's hard to see what's causing this particular staging behavior
Pinged @robertjchen since he's got context on the original PR and might be able to lend some insight here
Looks like - at least on dev - when approving the report, it's the optimisticIOUReportData from here that is overwriting the amount with the full (held + non-held) amount, even though the amount is correctly being set in optimisticApprovedReportActionhere.
@NikkiWines@trjExpensify We have this bug #41652 here this is the part of this issue since we don't implement the optimistic data when we approve partial. Can you please take a look and re-open this issue.
@NikkiWines@trjExpensify We have this bug #41652 here this is the part of this issue since we don't implement the optimistic data when we approve partial. Can you please take a look and re-open this issue.
Been focused on some other urgent issues but I will look into this during the week. From a quick glance it looks like there's some activity in the linked issue for resolving the issue as well. Re-opening for now so it doesn't fall off my radar.
Activity
melvin-bot commentedon Mar 31, 2024
Triggered auto assignment to @NikkiWines (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Mar 31, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Mar 31, 2024
We think that this bug might be related to #wave-collect - Release 1
lanitochka17 commentedon Mar 31, 2024
@NikkiWines FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
NikkiWines commentedon Apr 2, 2024
This definitely looks like a regression / unhandled case from #33124. I've been trying to reproduce locally but the behavior is pretty buggy on
mainright now (crashing when holding an expense, approving the full total and not the held amount, paying doesn't work because the "The requested amount has changed") so it's hard to see what's causing this particular staging behaviorPinged @robertjchen since he's got context on the original PR and might be able to lend some insight here
NikkiWines commentedon Apr 2, 2024
Looks like - at least on dev - when approving the report, it's the
optimisticIOUReportDatafrom here that is overwriting theamountwith the full (held + non-held) amount, even though theamountis correctly being set inoptimisticApprovedReportActionhere.robertjchen commentedon Apr 2, 2024
Thanks for the report! Definitely related to the changes there: #33124 and we'll be addressing it. Not a deploy blocker per the sentiments here
40 remaining items
trjExpensify commentedon Apr 25, 2024
Hit prod two days ago, closing!
nkdengineer commentedon May 6, 2024
@NikkiWines @trjExpensify We have this bug #41652 here this is the part of this issue since we don't implement the optimistic data when we approve partial. Can you please take a look and re-open this issue.
NikkiWines commentedon May 8, 2024
Been focused on some other urgent issues but I will look into this during the week. From a quick glance it looks like there's some activity in the linked issue for resolving the issue as well. Re-opening for now so it doesn't fall off my radar.
trjExpensify commentedon May 8, 2024
I think we can use the other issue for this follow-up. @nkdengineer I've assigned you for the C+ review on that.
NikkiWines commentedon May 8, 2024
Sounds good, re-closing this then