Skip to content

[HOLD for payment 2024-04-25] [$500] IOU - Missing green checkmark next to Total amount after paying request offline #39357

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4465715
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any DM where there is unsettled IOU.
  3. Click on the IOU preview.
  4. Go offline.
  5. Click Pay elsewehre.

Expected Result:

A green checkmark will be present next to Total amount after paying the amount (production behavior).

Actual Result:

Green checkmark is not present next to Total amount after paying the amount, but the checkmark is present in IOU preview.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6434183_1711974777973.bandicam_2024-04-01_20-28-41-567.mp4

Bug6434183_1711974777959!bandicam_2024-04-01_20-28-54-968

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f5527691d839335a
  • Upwork Job ID: 1775053032402595840
  • Last Price Increase: 2024-04-02
  • Automatic offers:
    • alitoshmatov | Reviewer | 0
    • bernhardoj | Contributor | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 1, 2024
  2. melvin-bot commented on Apr 1, 2024

    @melvin-bot

    Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Apr 1, 2024

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. github-actions commented on Apr 1, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Apr 1, 2024

    @izarutskaya
    Author

    @johncschuster I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Apr 1, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. izarutskaya commented on Apr 1, 2024

    @izarutskaya
    Author

    Production

    bandicam.2024-04-01.20-33-07-003.mp4
  8. marcaaron commented on Apr 1, 2024

    @marcaaron
    Contributor

    @lakchote is offline. This looks to me to be pretty minor so I am removing the blocker.

  9. 26 remaining items

  10. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-25. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
    • [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@alitoshmatov] Determine if we should create a regression test for this bug.
    • [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. johncschuster commented on Apr 26, 2024

    @johncschuster
    Contributor

    @alitoshmatov, can you please complete the BZ Checklist above?

  14. johncschuster commented on Apr 26, 2024

    @johncschuster
    Contributor

    Payment has been issued!

  15. alitoshmatov commented on Apr 29, 2024

    @alitoshmatov
    Contributor
  16. johncschuster commented on May 1, 2024

    @johncschuster
    Contributor

    Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions