You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-04-15] IOU - Skeleton IOU preview appears in IOU details page when there is one request #39403
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
The empty skeleton report action is added for a one-transaction IOU Report view.
What is the root cause of that problem?
This was caused by #36934 which introduced the one-transaction view.
The reason is that we filter out the IOU Report Action from the list if it's a single-transaction report.
But later here, we build an optimistic report preview action (the skeleton one) if the amount of filtered transactions is less than reportPreviewAction?.childMoneyRequestCount:
Oh, yep - definitely introduced by #36934. We should be using combinedReportActions there and also if we've passed a transactionThreadReport we know that the report is a one-transaction report and should skip the optimistic preview.
changed the title [-]IOU - Skeleton IOU preview appears in IOU details page when there is one request[/-][+][HOLD for payment 2024-04-15] IOU - Skeleton IOU preview appears in IOU details page when there is one request[/+]on Apr 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
melvin-bot commentedon Apr 2, 2024
Triggered auto assignment to @puneetlath (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.kbecciv commentedon Apr 2, 2024
We think that this bug might be related to #wave-collect - Release 1
github-actions commentedon Apr 2, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
paultsimura commentedon Apr 2, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The empty skeleton report action is added for a one-transaction IOU Report view.
What is the root cause of that problem?
This was caused by #36934 which introduced the one-transaction view.
The reason is that we filter out the IOU Report Action from the list if it's a single-transaction report.
But later here, we build an optimistic report preview action (the skeleton one) if the amount of filtered transactions is less than
reportPreviewAction?.childMoneyRequestCount:App/src/pages/home/report/ReportActionsView.tsx
Lines 503 to 521 in 1aac6e0
What changes do you think we should make in order to solve the problem?
We need to count for the special one-transaction case now, and change the condition to:
Where the
isOneTransactionViewmight bereportPreviewAction?.childMoneyRequestCount === 1(need to verify this deeper into the original PR).What alternative solutions did you explore? (Optional)
NikkiWines commentedon Apr 2, 2024
Oh, yep - definitely introduced by #36934. We should be using
combinedReportActionsthere and also if we've passed atransactionThreadReportwe know that the report is a one-transaction report and should skip the optimistic preview.NikkiWines commentedon Apr 2, 2024
@puneetlath I'll spin up a PR to handle the couple blockers that #36934 introduced, so i can take this over if you'd like
melvin-bot commentedon Apr 2, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Apr 2, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
NikkiWines commentedon Apr 2, 2024
No skeleton on staging 🎊
Screen.Recording.2024-04-02.at.15.13.01.mov
[-]IOU - Skeleton IOU preview appears in IOU details page when there is one request[/-][+][HOLD for payment 2024-04-15] IOU - Skeleton IOU preview appears in IOU details page when there is one request[/+]melvin-bot commentedon Apr 8, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-15. 🎊