Skip to content

Web - Scan receipt - Banner in header with Scanning and prompt are missing #39414

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4468880
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open the App
  2. Navigate to the workspace chat as the employee
  3. Select the option to Request money > Scan receipt
  4. Select the option to upload a receipt
  5. Upload a receipt file
  6. Click on Request

Expected Result:

When opening request details, there's a banner in the header indicating the scan is in progress and "Only you can see this receipt when it's scanning. Check back later or enter the details now."

Actual Result:

When opening the request details, "NextStep" These expenses are scheduled to automatically submit on Sunday! No further action required! This report may be selected at random for manual approval. is displayed.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435553_1712061712632.missingbannerprompt.mp4

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Apr 2, 2024

    @melvin-bot

    Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Apr 2, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. kbecciv commented on Apr 2, 2024

    @kbecciv
    Author

    Not reproducible in Production

    prodscan.1.mp4

    image

  4. kbecciv commented on Apr 2, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave-collect - Release 1

  5. NikkiWines commented on Apr 2, 2024

    @NikkiWines
    Contributor

    This is tied to #36934 and we'll need to have a larger discussion on how to handle the combined status header for the moneyReuqest and moneyReport for a one-transaction view

    cc: @shawnborton

  6. NikkiWines commented on Apr 2, 2024

    @NikkiWines
    Contributor

    I don't think we should block on this personally but it'll definitely need to be updated.

  7. shawnborton commented on Apr 2, 2024

    @shawnborton
    Contributor

    Sounds good - can you raise that discussion in the #vip-split room and we can discuss from there? I think we would just add the banner to the report view and add "Scanning in progress" in place of the amount, much like we do in the preview card. Thoughts?

  8. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 2, 2024
  9. NikkiWines commented on Apr 2, 2024

    @NikkiWines
    Contributor

    Yep, currently fixing the blockers that can be resolved more quickly but will raise it afterwards.

  10. 1 remaining item

  11. removed their assignment
    on Apr 2, 2024
  12. NikkiWines commented on Apr 3, 2024

    @NikkiWines
    Contributor

    Posted here

  13. NikkiWines commented on Apr 6, 2024

    @NikkiWines
    Contributor

    Discussion is underway

  14. NikkiWines commented on Apr 8, 2024

    @NikkiWines
    Contributor

    Discussion is still ongoing, dropping to weekly until we get a consensus

  15. NikkiWines commented on Apr 22, 2024

    @NikkiWines
    Contributor

    Going to close this out in favour of #39989 that arose as part of the aforementioned slack discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions