You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-10] [$250] [Wave Collect] Disable all but the default distance rate when feature is disabled same for categories and tags #39463
When the Distance Rates feature is disabled in NewDot, the distance rates remain enabled. Similarly to other features in the App, we should disable the rates when the feature is disabled.
However, this is also not yet implemented optimistically for tags and categories. This is an edge case that helps in cases of rare offline usage, and as such, it was not noted as regression.
When we disable the categories and tags feature in the backend, we also disable any enabled categories and tags. We need to do the same optimistically in the client (failure data should revert the state to the one before toggling the feature off).
Solution
When the distance rates feature is turned off in NewDot, go through all the distance rates on the policy and disable them except the Default Rate if available. If it's not available, keep the first rate that you go over as enabled and disable all the rest. We need to keep one enabled.
For tags and categories, make sure to turn off the requiresCategory and requiresTag optimistically and then all the tags, even multi-level.
Similarly to other features in the App, we should disable the rates when the feature is disabled (we disable all categories, tags and taxes when the feature is disabled)
Apart from the default or whatever that is, right?
changed the title [-][Wave Collect] [Distance] Disable all but the default distance rate when feature is disabled[/-][+][Wave Collect] [Distance rates] Disable all but the default distance rate when feature is disabled[/+]on Apr 5, 2024
Activity
melvin-bot commentedon Apr 2, 2024
Job added to Upwork: https://www.upwork.com/jobs/~010ba691024d0e69b3
melvin-bot commentedon Apr 2, 2024
Triggered auto assignment to Contributor Plus for review of internal employee PR - @getusha (
Internal)melvin-bot commentedon Apr 2, 2024
Triggered auto assignment to @kadiealexander (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.mountiny commentedon Apr 4, 2024
Will try to look into this tomorrow
trjExpensify commentedon Apr 5, 2024
Apart from the default or whatever that is, right?
[-][Wave Collect] [Distance] Disable all but the default distance rate when feature is disabled[/-][+][Wave Collect] [Distance rates] Disable all but the default distance rate when feature is disabled[/+]85 remaining items
kadiealexander commentedon Jul 14, 2024
@getusha @mountiny do we need a regession test here?
kadiealexander commentedon Jul 15, 2024
The contracts expired so I've resent them here. Payouts due:
Upwork job is here.
dominictb commentedon Jul 15, 2024
@kadiealexander Hi, this issue was created on Apr 3, so according to the official post here, this one's initial price should remain at $500
kadiealexander commentedon Jul 16, 2024
Thanks @dominictb, I've updated the offers.
dominictb commentedon Jul 16, 2024
@kadiealexander I accepted it, thank you
kadiealexander commentedon Jul 17, 2024
@getusha please share the regression test steps.
getusha commentedon Jul 17, 2024
Regression Test Proposal
Categoriesfeaturedistance ratesfeatureDistance ratespageTagspageTagsfeatureTagspageDo we agree 👍 or 👎
cc @mountiny @dominictb
getusha commentedon Jul 18, 2024
Accepted the offer @kadiealexander