Skip to content

[Due for payment 2025-09-12] [Live Markdown] Support inline code background style #39518

Closed

Description

@thienlnam

https://expensify.slack.com/archives/C049HHMV9SM/p1712094742944359

Now that live markdown preview is out on production - let's add support for the background style for inline code

It should use the same font and background style, but currently doesn't.

image

Issue OwnerCurrent Issue Owner: @lschurr

Activity

  1. self-assigned this
    on Apr 3, 2024
  2. melvin-bot commented on Apr 3, 2024

    @melvin-bot
  3. melvin-bot commented on Apr 3, 2024

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  4. thienlnam commented on Apr 3, 2024

    @thienlnam
    ContributorAuthor

    Added to the main tracking issue as part of HIGH: #36071

  5. lschurr commented on Apr 11, 2024

    @lschurr
    Contributor

    Anything needed from BZ on this one @thienlnam?

  6. thienlnam commented on Apr 11, 2024

    @thienlnam
    ContributorAuthor

    Not at this time, we'll probably need payment to the C+ that reviews in the future but that's further away

  7. tomekzaw commented on Apr 12, 2024

    @tomekzaw
    Contributor

    We're working on it.

    iOS

    I've asked @maksg from SWM to implement the iOS part. Here's the draft PR to Live Markdown:

    Android

    @maksg from SWM is also working on the Android part.

    Web

    @Skalakid had a working PoC some time ago, I will ask him to submit a PR for web.

  8. 123 remaining items

  9. melvin-bot commented on Sep 5, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.1-20 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-12. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Sep 5, 2025

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@tomekzaw / @BartoszGrajdek] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  11. lschurr commented on Sep 12, 2025

    @lschurr
    Contributor

    @dangrous @thienlnam could you confirm the price on this one?

  12. melvin-bot commented on Sep 12, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @tomekzaw is from an agency-contributor and not due payment
    • ROLE: @BartoszGrajdek is from an agency-contributor and not due payment

    BugZero Checklist (@lschurr)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. dangrous commented on Sep 15, 2025

    @dangrous
    Contributor

    this is all expert contributors, right? I don't think there's separate payment needed - but correct me if I'm wrong @thienlnam

  14. lschurr commented on Sep 15, 2025

    @lschurr
    Contributor

    Looks like it to me @dangrous. I updated the Payment Summary and am going to close without payment.

  15. dukenv0307 commented on Sep 19, 2025

    @dukenv0307
    Contributor

    @jmusial This PR is still in draft. Can you please update the status here? cc @lschurr Can you please re-open? I think it's not done

  16. dukenv0307 commented on Sep 23, 2025

    @dukenv0307
    Contributor

    @jmusial kindly bump

  17. jmusial commented on Sep 24, 2025

    @jmusial
    Contributor

    hey @dukenv0307 yeah, sorry missed that one.

    As far as I know @Skalakid touched up the implementation for the web, so that's done. There are still native platforms to implement. I need to update with @war-in and will come back with full update tomorrow.

    EDIT: I think the PR is no longer relevant as we chose to implement it in LM lib

  18. jmusial commented on Sep 24, 2025

    @jmusial
    Contributor

    OK, so confirming from the msg above:

    • Web is done
    • @war-in will handle native platforms implementation in live-markdown
    • PR will be has been closed as no longer relevant
    • this issue should NOT be closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2NewFeatureSomething to build that is a new item.

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions