You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Taxes - App crashes when changing tax rate to 0% on native apps and it shows 00 on web #39600
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Activity
melvin-bot commentedon Apr 4, 2024
Triggered auto assignment to @srikarparsi (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
kbecciv commentedon Apr 4, 2024
We think that this bug might be related to #wave-collect - Release 1
ZhenjaHorbach commentedon Apr 4, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Taxes - App crashes when changing tax rate to 0% on native apps and it shows 00 on web
What is the root cause of that problem?
The main problem with issue is that
shouldShowTaxcan return numberApp/src/components/ReportActionItem/MoneyRequestView.tsx
Line 159 in 136898c
As result we show 0 like text(For web) instead hide this element
For native we get crash
App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 435 to 446 in 136898c
App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 448 to 459 in 136898c
What changes do you think we should make in order to solve the problem?
To fix this issue we can we can convert this value to boolean (
!!shouldShowTax)App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 435 to 446 in 136898c
App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 448 to 459 in 136898c
But it's a little unclear here
Should we hide the ability to select taxes when we have chosen the default value (0)?
Because in this case we have a slightly incorrect condition that hides the item menu when the tax value is 0
App/src/components/ReportActionItem/MoneyRequestView.tsx
Line 159 in 136898c
What alternative solutions did you explore? (Optional)
NA
MonilBhavsar commentedon Apr 4, 2024
Looking
jasperhuangg commentedon Apr 4, 2024
PR merged ^ CPing now
19 remaining items
johncschuster commentedon Apr 5, 2024
Changing the bounty to $500, as it was issued prior to 2024-04-05.
johncschuster commentedon Apr 5, 2024
@allroundexperts I've invited you to the job, here. Can you accept that and ping me when you've done it so I can issue payment? Thank you!
allroundexperts commentedon Apr 11, 2024
Thanks @johncschuster, but I get paid through NewDot. Can you please write a payment summary instead? Thanks!
melvin-bot commentedon Apr 19, 2024
@johncschuster, @allroundexperts, @MonilBhavsar, @srikarparsi Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Apr 23, 2024
@johncschuster, @allroundexperts, @MonilBhavsar, @srikarparsi 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Apr 25, 2024
@johncschuster, @allroundexperts, @MonilBhavsar, @srikarparsi 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
melvin-bot commentedon Apr 29, 2024
@johncschuster, @allroundexperts, @MonilBhavsar, @srikarparsi 12 days overdue now... This issue's end is nigh!
melvin-bot commentedon May 2, 2024
This issue has not been updated in over 14 days. @johncschuster, @allroundexperts, @MonilBhavsar, @srikarparsi eroding to Weekly issue.
johncschuster commentedon May 3, 2024
Payment Summary
C+ Reviewer - @allroundexperts - $500 to be paid via Manual Request
JmillsExpensify commentedon May 4, 2024
$500 approved for @allroundexperts
srikarparsi commentedon May 14, 2024
Is this good to close out @johncschuster?
MonilBhavsar commentedon Jun 5, 2024
Looks like everyone is paid out, so we can close this one.