You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Chat - Second and subsequent messages not displayed in chat until chat reloaded #39650
Version Number: 1.4.60-2 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
This definitely just seems like a case of Pusher being really slow to send the updates, I don't think this needs to be a blocker since if there is a problem it exists in the back-end anyways. Still probably a good thing to investigate,
In the video it looks like pusher events with the report updates are reaching the other client, but the report actions maybe not?
The steps are somewhat confusing to me when it mixes account A/B and main/secondary device. Is the "secondary/main device" only mentioned to say that both accounts are logged in simultaneously in different devices?
Tested in production, and it works fine there. Here is a comparison of the pusher events received in the front end in staging vs production. Both look the same to me, so I think the update shape or the backend is not the problem. The staging frontend seems to be ignoring the update for some reason.
Activity
melvin-bot commentedon Apr 4, 2024
Triggered auto assignment to @hayata-suenaga (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Apr 4, 2024
@hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
jasperhuangg commentedon Apr 4, 2024
This definitely just seems like a case of Pusher being really slow to send the updates, I don't think this needs to be a blocker since if there is a problem it exists in the back-end anyways. Still probably a good thing to investigate,
aldo-expensify commentedon Apr 4, 2024
In the video it looks like pusher events with the report updates are reaching the other client, but the report actions maybe not?
The steps are somewhat confusing to me when it mixes account A/B and main/secondary device. Is the "secondary/main device" only mentioned to say that both accounts are logged in simultaneously in different devices?
aldo-expensify commentedon Apr 4, 2024
@lanitochka17 is this step wrong?
The "account A" is supposed to be using the "main device", right?
aldo-expensify commentedon Apr 4, 2024
Reproduced
aldo-expensify commentedon Apr 4, 2024
I can see that the
SendFetchableUpdatesjob pushed the update with the newreportActionto both accounts in these logs.The receiver account is 16596361 (aldo+test39650-account-a@expensifail.com)
The sender account is 16596362 (aldo+test39650-account-b@expensifail.com)
When looking in dev tools > Application > keyvaluepair >
reportActions_6583009741597437, the comment was never added there.I can see in the console that the event with the comment did reach the front end:
[info] [Report] Handled multipleEvents event sent by Pusher - {"updates":[{"data":[{"key":"report_6583009741597437","onyxMethod":"merge","value":{"lastActorAccountID":16596362,"lastMentionTime":"2024-04-04 23:29:37.409","lastMessageText":"second message","lastVisibleActionCreated":"2024-04-04 23:29:37.409","maxSequenceNumber":2,"reportID":"6583009741597437"}},{"key":"reportActions_6583009741597437","onyxMethod":"merge","shouldNotify":true,"value":{"4501046319237944138":{"actionName":"ADDCOMMENT","actorAccountID":16596362,"automatic":false,"avatar":"https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_3.png","created":"2024-04-04 23:29:37.409","isAttachment":false,"lastModified":"2024-04-04 23:29:37.409","message":[{"deleted":"","html":"second message","isDeletedParentAction":false,"isEdited":false,"reactions":[],"text":"second message","type":"COMMENT","whisperedTo":[]}],"originalMessage":{"html":"second message","lastModified":"2024-04-04 23:29:37.409"},"person":[{"style":"strong","text":"aldo+test39650-account-b@expensifail.com","type":"TEXT"}],"previousReportActionID":"1864704912092156641","reportActionID":"4501046319237944138","reportActionTimestamp":1712273377409,"sequenceNumber":2,"shouldShow":true,"timestamp":1712273377,"whisperedToAccountIDs":[]}}}],"eventType":"onyxApiUpdate"}],"lastUpdateID":239122686,"previousUpdateID":239122475}but somehow it wasn't applied in Onyx? 🤷 X 1000
aldo-expensify commentedon Apr 4, 2024
Tested in production, and it works fine there. Here is a comparison of the pusher events received in the front end in staging vs production. Both look the same to me, so I think the update shape or the backend is not the problem. The staging frontend seems to be ignoring the update for some reason.
Comparison onyx updates prod/staging
{ "updates": [ { "data": [ { "key": "report_1869229811124868", "onyxMethod": "merge", "value": { "lastActorAccountID": 16596388, "lastMentionTime": "2024-04-04 23:42:24.502", "lastMessageText": "1", "lastVisibleActionCreated": "2024-04-04 23:42:24.502", "maxSequenceNumber": 4, "reportID": "1869229811124868" } }, { "key": "reportActions_1869229811124868", "onyxMethod": "merge", "shouldNotify": true, "value": { "4585206169631678243": { "actionName": "ADDCOMMENT", "actorAccountID": 16596388, "automatic": false, "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_5.png", "created": "2024-04-04 23:42:24.502", "isAttachment": false, "lastModified": "2024-04-04 23:42:24.502", "message": [ { "deleted": "", "html": "1", "isDeletedParentAction": false, "isEdited": false, "reactions": [], "text": "1", "type": "COMMENT", "whisperedTo": [] } ], "originalMessage": { "html": "1", "lastModified": "2024-04-04 23:42:24.502" }, "person": [ { "style": "strong", "text": "aldo+test39650-account-b-prod@expensifail.com", "type": "TEXT" } ], "previousReportActionID": "7546131154617022882", "reportActionID": "4585206169631678243", "reportActionTimestamp": 1712274144502, "sequenceNumber": 4, "shouldShow": true, "timestamp": 1712274144, "whisperedToAccountIDs": [] } } } ], "eventType": "onyxApiUpdate" } ], "lastUpdateID": 239140017, "previousUpdateID": 239139159 }{ "updates": [ { "data": [ { "key": "report_6583009741597437", "onyxMethod": "merge", "value": { "lastActorAccountID": 16596362, "lastMentionTime": "2024-04-04 23:42:53.899", "lastMessageText": "1", "lastVisibleActionCreated": "2024-04-04 23:42:53.899", "maxSequenceNumber": 5, "reportID": "6583009741597437" } }, { "key": "reportActions_6583009741597437", "onyxMethod": "merge", "shouldNotify": true, "value": { "5843399410900401428": { "actionName": "ADDCOMMENT", "actorAccountID": 16596362, "automatic": false, "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_3.png", "created": "2024-04-04 23:42:53.899", "isAttachment": false, "lastModified": "2024-04-04 23:42:53.899", "message": [ { "deleted": "", "html": "1", "isDeletedParentAction": false, "isEdited": false, "reactions": [], "text": "1", "type": "COMMENT", "whisperedTo": [] } ], "originalMessage": { "html": "1", "lastModified": "2024-04-04 23:42:53.899" }, "person": [ { "style": "strong", "text": "aldo+test39650-account-b@expensifail.com", "type": "TEXT" } ], "previousReportActionID": "643022834268743072", "reportActionID": "5843399410900401428", "reportActionTimestamp": 1712274173899, "sequenceNumber": 5, "shouldShow": true, "timestamp": 1712274173, "whisperedToAccountIDs": [] } } } ], "eventType": "onyxApiUpdate" } ], "lastUpdateID": 239140637, "previousUpdateID": 239136944 }aldo-expensify commentedon Apr 5, 2024
Tried to reproduce in dev using
mainand tag1.4.60-7(current staging) and couldn't reproducealdo-expensify commentedon Apr 5, 2024
Asked in slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1712274581354349
The cause seems to be this PR #38997. Testing the ad-hoc build with the revert #39668 makes the problem disappear.
I also noticed that in staging, when the bug happens, the following log lines never appear:
aldo-expensify commentedon Apr 5, 2024
This is fixed now: #39668 (comment)
hayata-suenaga commentedon Apr 5, 2024
thank you Aldo for triaging this issue. Removing myself from assignment as I didn't fix the issue