You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Track Tax] Support tax tracking for split requests with workspace #39690
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@garrettmknight I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Demoting from deploy blocker, because it's not an app blocker. This bug occurs because server is sending taxCode as null initially. We can hide the field at the frontend, but that won't be real fix for the issue. Since this is behind policyExpensechat beta, I think it's fine.
We're rolling out changes incrementally and tax support for split bill case is yet to be released. This issue will be fixed when SplitBill command accepts taxCode param and sends it back
Activity
melvin-bot commentedon Apr 5, 2024
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Apr 5, 2024
Triggered auto assignment to @danieldoglas (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 5, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Apr 5, 2024
@garrettmknight I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Apr 5, 2024
We think this issue might be related to the #collect project.
MonilBhavsar commentedon Apr 5, 2024
Taking a look...
MonilBhavsar commentedon Apr 5, 2024
Demoting from deploy blocker, because it's not an app blocker. This bug occurs because server is sending
taxCodeas null initially. We can hide the field at the frontend, but that won't be real fix for the issue. Since this is behind policyExpensechat beta, I think it's fine.We're rolling out changes incrementally and tax support for split bill case is yet to be released. This issue will be fixed when
SplitBillcommand accepts taxCode param and sends it back94 remaining items
melvin-bot commentedon Jun 20, 2024
Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.
garrettmknight commentedon Jun 20, 2024
@dukenv0307 offer is out to you. 50% x $250 for a regression = $125
Upwork offer
garrettmknight commentedon Jun 24, 2024
All set with payment - @dukenv0307 any regression test necessary?
dukenv0307 commentedon Jun 25, 2024
@garrettmknight I already post the regression test in here
garrettmknight commentedon Jun 25, 2024
Ah, missed the double post. Closing!