Skip to content

[$250] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Track Tax] Support tax tracking for split requests with workspace #39690

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.60-8
Reproducible in staging?: Yes
Reproducible in production?: No, new feature
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • User is an employee of Collect workspace.
  • The Collect workspace has several tax rates.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a split scan request with an invalid receipt and include a tax rate.
  4. When the scanning fails, go to split preview.
  5. Manually enter amount and merchant and save it with a tax rate.
  6. Go to transaction thread of the split request.

Expected Result:

The selected tax rate will show up under Tax rate row in transaction thread.

Actual Result:

Tax rate row is blank in transaction thread, unless tax amount is edited.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6438746_1712288415598.20240405_113200.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0126969ac729dd1083
  • Upwork Job ID: 1776200720994766848
  • Last Price Increase: 2024-06-20
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @dukenv0307

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 5, 2024
  2. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Apr 5, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Apr 5, 2024

    @izarutskaya
    Author

    @garrettmknight I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Apr 5, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. MonilBhavsar commented on Apr 5, 2024

    @MonilBhavsar
    Contributor

    Taking a look...

  8. MonilBhavsar commented on Apr 5, 2024

    @MonilBhavsar
    Contributor

    Demoting from deploy blocker, because it's not an app blocker. This bug occurs because server is sending taxCode as null initially. We can hide the field at the frontend, but that won't be real fix for the issue. Since this is behind policyExpensechat beta, I think it's fine.
    We're rolling out changes incrementally and tax support for split bill case is yet to be released. This issue will be fixed when SplitBill command accepts taxCode param and sends it back

  9. 94 remaining items

  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 20, 2024
  11. melvin-bot commented on Jun 20, 2024

    @melvin-bot

    Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

  12. removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 20, 2024
  13. garrettmknight commented on Jun 20, 2024

    @garrettmknight
    Contributor

    @dukenv0307 offer is out to you. 50% x $250 for a regression = $125
    Upwork offer

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    InternalRequires API changes or must be handled by Expensify staff
    on Jun 20, 2024
  15. garrettmknight commented on Jun 24, 2024

    @garrettmknight
    Contributor

    All set with payment - @dukenv0307 any regression test necessary?

  16. dukenv0307 commented on Jun 25, 2024

    @dukenv0307
    Contributor

    @garrettmknight I already post the regression test in here

  17. garrettmknight commented on Jun 25, 2024

    @garrettmknight
    Contributor

    Ah, missed the double post. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions