You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[PAID] [$250] Taxes - App crashes when visiting transaction thread with invalid tax rate on a fresh session #39695
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@strepanier03 I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
changed the title [-][$250] Taxes - App crashes when visiting transaction thread with invalid tax rate on a fresh session[/-][+][HOLD for payment 2024-04-15] [$250] Taxes - App crashes when visiting transaction thread with invalid tax rate on a fresh session[/+]on Apr 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@shubham1206agra] Determine if we should create a regression test for this bug.
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
I'm fairly certain PR reviews that don't require a lot of changes or intense testing should be $250, even prior to the price change that went into effect on April 6th.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required
[@shubham1206agra] Determine if we should create a regression test for this bug. No
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-04-15] [$250] Taxes - App crashes when visiting transaction thread with invalid tax rate on a fresh session[/-][+][PAID] [$250] Taxes - App crashes when visiting transaction thread with invalid tax rate on a fresh session[/+]on Apr 19, 2024
Activity
melvin-bot commentedon Apr 5, 2024
Triggered auto assignment to @Gonals (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 5, 2024
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Apr 5, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Apr 5, 2024
@strepanier03 I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Apr 5, 2024
We think this issue might be related to the #collect project.
melvin-bot commentedon Apr 5, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01bfd8b2886cedb8f1
28 remaining items
[-][$250] Taxes - App crashes when visiting transaction thread with invalid tax rate on a fresh session[/-][+][HOLD for payment 2024-04-15] [$250] Taxes - App crashes when visiting transaction thread with invalid tax rate on a fresh session[/+]melvin-bot commentedon Apr 8, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-15. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 8, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
strepanier03 commentedon Apr 15, 2024
@shubham1206agra - Please finish up the checklist when you have a chance and I'll finish up on my end once you do. Thanks!
shubham1206agra commentedon Apr 17, 2024
@MonilBhavsar Can you confirm if this issue is eligible for $500 compensation as the issue was created before April 6th?
strepanier03 commentedon Apr 17, 2024
I'm fairly certain PR reviews that don't require a lot of changes or intense testing should be $250, even prior to the price change that went into effect on April 6th.
shubham1206agra commentedon Apr 18, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2024-04-15] [$250] Taxes - App crashes when visiting transaction thread with invalid tax rate on a fresh session[/-][+][PAID] [$250] Taxes - App crashes when visiting transaction thread with invalid tax rate on a fresh session[/+]strepanier03 commentedon Apr 19, 2024
Thanks for the checklist @shahinyan11- I've paid out the contract and closed it in Upwork. Thanks again!