Skip to content

[PAID] [$250] Taxes - App crashes when visiting transaction thread with invalid tax rate on a fresh session #39695

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.60-8
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • Admin and employee are in the same Collect workspace.
  • The Collect workspace has several tax rates.
  1. Go to staging.new.expensify.com
  2. [Employee] Go to workspace chat.
  3. [Employee] Create manual request with a tax rate in workspace chat.
  4. [Admin] On Old Dot, delete the tax rate selected in Step 3.
  5. [Employee] Go to Settings > About > Troubleshoot > Clear cache and restart > Reset and refresh (relogin can also be done).
  6. [Employee] Navigate to the transaction thread with invalid tax rate.

Expected Result:

App should not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6438754_1712289000506.20240405_114247.mp4

Bug6438754_1712289000497!staging.new.expensify.com-1712288865325.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bfd8b2886cedb8f1
  • Upwork Job ID: 1776209471760666624
  • Last Price Increase: 2024-04-05
  • Automatic offers:
    • shubham1206agra | Contributor | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 5, 2024
  2. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. github-actions commented on Apr 5, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Apr 5, 2024

    @izarutskaya
    Author

    @strepanier03 I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Apr 5, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 5, 2024
  8. melvin-bot commented on Apr 5, 2024

    @melvin-bot
  9. 28 remaining items

  10. changed the title [-][$250] Taxes - App crashes when visiting transaction thread with invalid tax rate on a fresh session[/-] [+][HOLD for payment 2024-04-15] [$250] Taxes - App crashes when visiting transaction thread with invalid tax rate on a fresh session[/+] on Apr 8, 2024
  11. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-15. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
    • [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@shubham1206agra] Determine if we should create a regression test for this bug.
    • [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. strepanier03 commented on Apr 15, 2024

    @strepanier03
    Contributor

    @shubham1206agra - Please finish up the checklist when you have a chance and I'll finish up on my end once you do. Thanks!

  15. shubham1206agra commented on Apr 17, 2024

    @shubham1206agra
    Contributor

    @MonilBhavsar Can you confirm if this issue is eligible for $500 compensation as the issue was created before April 6th?

  16. strepanier03 commented on Apr 17, 2024

    @strepanier03
    Contributor

    I'm fairly certain PR reviews that don't require a lot of changes or intense testing should be $250, even prior to the price change that went into effect on April 6th.

  17. shubham1206agra commented on Apr 18, 2024

    @shubham1206agra
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  18. changed the title [-][HOLD for payment 2024-04-15] [$250] Taxes - App crashes when visiting transaction thread with invalid tax rate on a fresh session[/-] [+][PAID] [$250] Taxes - App crashes when visiting transaction thread with invalid tax rate on a fresh session[/+] on Apr 19, 2024
  19. strepanier03 commented on Apr 19, 2024

    @strepanier03
    Contributor

    Thanks for the checklist @shahinyan11- I've paid out the contract and closed it in Upwork. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions