Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.60-8
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #33927
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition:
- User is an employee of Collect workspace with tax rates.
- Go to staging.new.expensify.com
- Go to workspace chat.
- Create a manual request with tax exempt (0%).
- Go to transaction thread.
- Click Tax amount.
- Save it without entering any amount.
- Repeat Step 5 and 6.
Expected Result:
In Step 6, when saving 0.00 tax amount, the system message will not show $NaN amount,
In Step 7, when saving 0.00 tax amount for the second time, the app will not show skeleton loading.
Actual Result:
In Step 6, $NaN is shown briefly in the system message.
In Step 7, transaction thread shows skeleton loading when saving 0.00 tax amount for second time.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6438827_1712298111790.20240405_141500.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01091a68b65c340a6a
- Upwork Job ID: 1776234872385998848
- Last Price Increase: 2024-04-05
- Automatic offers:
- DylanDylann | Reviewer | 0
Activity
melvin-bot commentedon Apr 5, 2024
Triggered auto assignment to @cristipaval (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 5, 2024
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Apr 5, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Apr 5, 2024
@bfitzexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Apr 5, 2024
We think this issue might be related to the #collect project.
MonilBhavsar commentedon Apr 5, 2024
Looking here...
33 remaining items
[-][$250] Taxes - Transaction thread shows skeleton loading when saving 0.00 tax amount for second time[/-][+][HOLD for payment 2024-04-15] [$250] Taxes - Transaction thread shows skeleton loading when saving 0.00 tax amount for second time[/+]melvin-bot commentedon Apr 8, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-15. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 8, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Apr 15, 2024
Payment Summary
Upwork Job
BugZero Checklist (@bfitzexpensify)
bfitzexpensify commentedon Apr 16, 2024
I don't think a specific regression test is needed for this - it should be caught in regular tax testing.
Payment complete, so closing this one out.
nkdengineer commentedon Jul 1, 2024
Sorry @bfitzexpensify It seems I wasn't paid here, could you reopen the issue to help with this?
TIA
bfitzexpensify commentedon Jul 1, 2024
@nkdengineer this one was paid on April 16th - title for the Upwork job was Reviewer - [$250] Taxes - Transaction thread shows skeleton loading when saving 0.00 tax amount for second time