Skip to content

[Track Tax] Expense request with tax amount higher than the tax rate limit can be created #39703

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.60-8
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR: #33927
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • Collect workspace has tax rates.
  • Workspace Currency Default has 20% tax.
  • Foreign Currency Default has 10% tax.
  1. Go to staging.new.expensify.com
  2. Go to Collect workspace chat.
  3. Start manual request flow using foreign currency.
  4. In confirmation page, click Show more.
  5. Keep the default tax rate, where it applies Workspace Currency Default (20%).
  6. Click Tax amount.
  7. Manually edit the tax amount to within 10% to 20% tax amount.
  8. Create the request.
  9. Go to transaction thread.
  10. Note that tax rate changes to Foreign Currency Default with 10% tax.
  11. Note the tax amount.

Expected Result:

In the transaction thread, the tax amount should readjust to the maximum limit of Foreign Currency Default (10%).

Actual Result:

In the transaction thread, the tax amount does not readjust to the maximum limit of Foreign Currency Default (10%).
It still shows the tax amount entered during the creation (Step 7), which is higher than the maximum limit of Foreign Currency Default (10%).

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6438830_1712298872398.20240405_142523.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 5, 2024
  2. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Apr 5, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Apr 5, 2024

    @izarutskaya
    Author

    @kevinksullivan I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Apr 5, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. self-assigned this
    on Apr 5, 2024
  8. 15 remaining items

  9. MonilBhavsar commented on Apr 22, 2024

    @MonilBhavsar
    Contributor

    Still on HOLD

  10. kevinksullivan commented on Apr 29, 2024

    @kevinksullivan
    Contributor

    Agree with wave-collect here.

  11. kevinksullivan commented on Apr 29, 2024

    @kevinksullivan
    Contributor

    Still on hold for #39616

  12. changed the title [-][HOLD #39616]Taxes - Expense request with tax amount higher than the tax rate limit can be created[/-] [+][HOLD #39616] [Track Tax] Expense request with tax amount higher than the tax rate limit can be created[/+] on May 2, 2024
  13. kevinksullivan commented on May 9, 2024

    @kevinksullivan
    Contributor

    @MonilBhavsar still looks like this is held?

  14. MonilBhavsar commented on May 10, 2024

    @MonilBhavsar
    Contributor

    Yes, correct. Very close for the other PR to merge, retest this and hopefully close this issue

  15. MonilBhavsar commented on May 13, 2024

    @MonilBhavsar
    Contributor

    We've merged the PR and this issue is not reproducible on main. So closing

  16. changed the title [-][HOLD #39616] [Track Tax] Expense request with tax amount higher than the tax rate limit can be created[/-] [+] [Track Tax] Expense request with tax amount higher than the tax rate limit can be created[/+] on May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions