Skip to content

Remove (NEW!) message after logout and update it to be unread count #3971

Closed

Description

@tugbadogan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  • Log in to a user
  • Make sure user has unread messages and web page has (NEW!) phrase in the title
  • If there's no unread messages, mark a message as unread
  • Log out

Expected Result:

Let's update this in the following two ways:

  1. Instead of appending (NEW!) when there are new messages, let's append (1) which is a count of the number of unread messages (similar to the desktop app icon shown below.
  2. The (1) message (currently (NEW!)) should be removed from the title bar upon logout.

image

Actual Result:

(NEW!) phrase stays in the page title

Screen.Recording.2021-07-10.at.16.04.06.mov

Workaround:

It doesn't prevent user from logging in or refreshing the page

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: v1.0.76-2
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

Activity

  1. MelvinBot commented on Jul 10, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @puneetlath (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Jul 10, 2021
  3. puneetlath commented on Jul 21, 2021

    @puneetlath
    Contributor

    @Expensify/design what should this be now that we moved from expensify.cash to new.expensify? Should the tab title just be "New Expensify" permanently?

  4. shawnborton commented on Jul 21, 2021

    @shawnborton
    Contributor

    That makes sense to me.

  5. puneetlath commented on Jul 21, 2021

    @puneetlath
    Contributor
  6. changed the title [-](NEW!) message title stays after logout[/-] [+]Remove (NEW!) message after logout and update it to be unread count[/+] on Jul 26, 2021
  7. puneetlath commented on Jul 26, 2021

    @puneetlath
    Contributor

    Ok I updated the issues based on that discussion. Done triaging, so unassigning myself and assigning Engineering !

  8. removed their assignment
    on Jul 26, 2021
  9. MelvinBot commented on Jul 26, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @HorusGoul (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  10. MelvinBot commented on Aug 3, 2021

    @MelvinBot
    Contributor

    @HorusGoul Whoops! This issue is 2 days overdue. Let's get this updated quick!

  11. MelvinBot commented on Aug 5, 2021

    @MelvinBot
    Contributor

    @HorusGoul Huh... This is 4 days overdue. Who can take care of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions