You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Android/iOS - Shortcut - Tapping shortcut track manual does not trigger any action #39863
Version Number: 1.4.61 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
Action Performed:
Launch app
Tap fab--- track expense---manual
Enter an amount and tap next
Tap track expense
Navigate back to LHN
Tap fab
Tap shortcut track manual
Expected Result:
Tapping shortcut track manual must direct to track manual page
Actual Result:
Tapping shortcut track manual does not trigger any action
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Here we do not have the startMoneyRequest action defined for CONST.QUICK_ACTIONS.TRACK_MANUAL, and hence it will return a empty string which is its default value:
changed the title [-]Android - Shortcut - Tapping shortcut track manual does not trigger any action[/-][+]Android/iOS - Shortcut - Tapping shortcut track manual does not trigger any action[/+]on Apr 15, 2024
Activity
melvin-bot commentedon Apr 8, 2024
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.lanitochka17 commentedon Apr 8, 2024
@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Apr 8, 2024
We think that this bug might be related to #vip-vsp
allgandalf commentedon Apr 8, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Nothing happens when we click on Track expense shortcut
What is the root cause of that problem?
This is reproducible in all platforms not just android.
We do not have case defined for
track expenseinnavigateToQuickActionApp/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js
Line 175 in 89b9cef
Here we do not have the
startMoneyRequestaction defined forCONST.QUICK_ACTIONS.TRACK_MANUAL, and hence it will return a empty string which is its default value:App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js
Lines 201 to 203 in 89b9cef
So it returns default value as empty string.
What changes do you think we should make in order to solve the problem?
We need to define the case for
track expense shortcut:This will route the user to
track expensepage through the shortcut.What alternative solutions did you explore? (Optional)
N/A
ZhenjaHorbach commentedon Apr 8, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Shortcut - Tapping shortcut track manual does not trigger any action
What is the root cause of that problem?
The main problem with the issue is that in this PR we added some new actions #39149
but didn't add navigation logic for them
What changes do you think we should make in order to solve the problem?
To fix this issue we can update our navigateToQuickAction and add some new actions related with
TRACK_EXPENSEApp/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js
Lines 175 to 203 in 9adb9ef
What alternative solutions did you explore? (Optional)
NA
melvin-bot commentedon Apr 12, 2024
@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-]Android - Shortcut - Tapping shortcut track manual does not trigger any action[/-][+]Android/iOS - Shortcut - Tapping shortcut track manual does not trigger any action[/+]muttmuure commentedon Apr 15, 2024
cc @thienlnam
muttmuure commentedon Apr 15, 2024
Posted ere: https://expensify.slack.com/archives/C066HJM2CAZ/p1713201165427219
allgandalf commentedon Apr 15, 2024
isn't this going to be external ? @muttmuure , similar issue related to track manual is external already: #40097
muttmuure commentedon Apr 17, 2024
@Gonals what's the plan with these?
https://github.com/Expensify/Expensify/issues/378892
Gonals commentedon Apr 18, 2024
This was expected, as track functionality wasn't implemented yet. This PRshould fix this, so I'm going to close 😁