Skip to content

Android/iOS - Shortcut - Tapping shortcut track manual does not trigger any action #39863

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.61
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

  1. Launch app
  2. Tap fab--- track expense---manual
  3. Enter an amount and tap next
  4. Tap track expense
  5. Navigate back to LHN
  6. Tap fab
  7. Tap shortcut track manual

Expected Result:

Tapping shortcut track manual must direct to track manual page

Actual Result:

Tapping shortcut track manual does not trigger any action

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442458_1712590087801.dp.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 8, 2024
  2. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. lanitochka17 commented on Apr 8, 2024

    @lanitochka17
    Author

    @muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Apr 8, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  5. allgandalf commented on Apr 8, 2024

    @allgandalf
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Nothing happens when we click on Track expense shortcut

    What is the root cause of that problem?

    This is reproducible in all platforms not just android.

    We do not have case defined for track expense in navigateToQuickAction


    Here we do not have the startMoneyRequest action defined for CONST.QUICK_ACTIONS.TRACK_MANUAL, and hence it will return a empty string which is its default value:

    So it returns default value as empty string.

    What changes do you think we should make in order to solve the problem?

    We need to define the case for track expense shortcut:

                case CONST.QUICK_ACTIONS.TRACK_MANUAL:
                    IOU.startMoneyRequest(CONST.IOU.TYPE.TRACK_EXPENSE, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.MANUAL);
                    return;

    This will route the user to track expense page through the shortcut.

    What alternative solutions did you explore? (Optional)

    N/A

  6. ZhenjaHorbach commented on Apr 8, 2024

    @ZhenjaHorbach
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Shortcut - Tapping shortcut track manual does not trigger any action

    What is the root cause of that problem?

    The main problem with the issue is that in this PR we added some new actions #39149
    but didn't add navigation logic for them

    What changes do you think we should make in order to solve the problem?

    To fix this issue we can update our navigateToQuickAction and add some new actions related with TRACK_EXPENSE

                case CONST.QUICK_ACTIONS.TRACK_MANUAL:
                    IOU.startMoneyRequest(CONST.IOU.TYPE.TRACK_EXPENSE, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.MANUAL);
                    return;
                case CONST.QUICK_ACTIONS.TRACK_SCAN:
                    IOU.startMoneyRequest(CONST.IOU.TYPE.TRACK_EXPENSE, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.SCAN);
                    return;
                case CONST.QUICK_ACTIONS.TRACK_DISTANCE:
                    IOU.startMoneyRequest(CONST.IOU.TYPE.TRACK_EXPENSE, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.DISTANCE);
                    return;
    

    const navigateToQuickAction = () => {
    switch (props.quickAction.action) {
    case CONST.QUICK_ACTIONS.REQUEST_MANUAL:
    IOU.startMoneyRequest(CONST.IOU.TYPE.REQUEST, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.MANUAL);
    return;
    case CONST.QUICK_ACTIONS.REQUEST_SCAN:
    IOU.startMoneyRequest(CONST.IOU.TYPE.REQUEST, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.SCAN);
    return;
    case CONST.QUICK_ACTIONS.REQUEST_DISTANCE:
    IOU.startMoneyRequest(CONST.IOU.TYPE.REQUEST, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.DISTANCE);
    return;
    case CONST.QUICK_ACTIONS.SPLIT_MANUAL:
    IOU.startMoneyRequest(CONST.IOU.TYPE.SPLIT, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.MANUAL);
    return;
    case CONST.QUICK_ACTIONS.SPLIT_SCAN:
    IOU.startMoneyRequest(CONST.IOU.TYPE.SPLIT, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.SCAN);
    return;
    case CONST.QUICK_ACTIONS.SPLIT_DISTANCE:
    IOU.startMoneyRequest(CONST.IOU.TYPE.SPLIT, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.DISTANCE);
    return;
    case CONST.QUICK_ACTIONS.SEND_MONEY:
    IOU.startMoneyRequest(CONST.IOU.TYPE.SEND, props.quickAction.chatReportID);
    return;
    case CONST.QUICK_ACTIONS.ASSIGN_TASK:
    Task.clearOutTaskInfoAndNavigate(props.quickAction.chatReportID, quickActionReport, _.get(props.quickAction, 'targetAccountID', 0));
    return;
    default:
    return '';
    }

    What alternative solutions did you explore? (Optional)

    NA

  7. melvin-bot commented on Apr 12, 2024

    @melvin-bot

    @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

  8. changed the title [-]Android - Shortcut - Tapping shortcut track manual does not trigger any action[/-] [+]Android/iOS - Shortcut - Tapping shortcut track manual does not trigger any action[/+] on Apr 15, 2024
  9. muttmuure commented on Apr 15, 2024

    @muttmuure
    Contributor
  10. muttmuure commented on Apr 15, 2024

    @muttmuure
    Contributor
  11. allgandalf commented on Apr 15, 2024

    @allgandalf
    Contributor

    isn't this going to be external ? @muttmuure , similar issue related to track manual is external already: #40097

  12. muttmuure commented on Apr 17, 2024

    @muttmuure
    Contributor
  13. Gonals commented on Apr 18, 2024

    @Gonals
    Contributor

    This was expected, as track functionality wasn't implemented yet. This PRshould fix this, so I'm going to close 😁

  14. self-assigned this
    on Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions