You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-05-09] [$250] [DEV]User invited by mentioning from a concierge whisper can't see parent message #39982
@m-natarajan : Tried steps in latest version of Chrome. I am not able to reproduce the issue in staging with email addresses created using same parent email (ones created using adding '+' in the email) as well as an entirely independent email address. I can see the parent of the thread for both users. Please see screenshot below.
But from a usability standpoint, it doesn't look like a parent - child tree view, rather is a flat list stating 'Thread' and 'Replies'. As an end user, I would have liked to have this view as a configurable entry.
changed the title [-][$250] [DEV]User invited by mentioning from a concierge whisper can't see parent message[/-][+][HOLD for payment 2024-05-09] [$250] [DEV]User invited by mentioning from a concierge whisper can't see parent message[/+]on May 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@fedirjh / @rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh / @rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh / @rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh / @rayane-djouah] Determine if we should create a regression test for this bug.
[@fedirjh / @rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Apr 10, 2024
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Apr 10, 2024
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
brkdavis commentedon Apr 10, 2024
@m-natarajan : Tried steps in latest version of Chrome. I am not able to reproduce the issue in staging with email addresses created using same parent email (ones created using adding '+' in the email) as well as an entirely independent email address. I can see the parent of the thread for both users. Please see screenshot below.
But from a usability standpoint, it doesn't look like a parent - child tree view, rather is a flat list stating 'Thread' and 'Replies'. As an end user, I would have liked to have this view as a configurable entry.
rayane-d commentedon Apr 10, 2024
@brkdavis this bug is currently only reproducible on main, not on staging
rayane-d commentedon Apr 10, 2024
@m-natarajan @zanyrenney this is reproducible now on staging; it may be a deploy blocker
melvin-bot commentedon Apr 10, 2024
Triggered auto assignment to @tylerkaraszewski (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.42 remaining items
rayane-d commentedon Apr 29, 2024
PR ready for review
[-][$250] [DEV]User invited by mentioning from a concierge whisper can't see parent message[/-][+][HOLD for payment 2024-05-09] [$250] [DEV]User invited by mentioning from a concierge whisper can't see parent message[/+]melvin-bot commentedon May 2, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-05-09. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 2, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
zanyrenney commentedon May 8, 2024
Payment summary
@fedirjh requires payment automatic offer (Reviewer) - paid $250 via Upwork
@rayane-djouah requires payment automatic offer (Contributor) paid $250 via Upwork
zanyrenney commentedon May 8, 2024
Oh oops. I am a day early actually @fedirjh I don't imagine there will be a regression from this but please LMK if there is.