Skip to content

[HOLD for payment 2024-05-09] [$250] [DEV]User invited by mentioning from a concierge whisper can't see parent message #39982

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Main
Reproducible in staging?: Main
Reproducible in production?: Main
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @rayane-djouah
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712697976186759

Action Performed:

  1. Click on FAB > Start chat
  2. Create a group chat with Users B and C
  3. Send a message in the group chat
  4. Right-click on the message > Reply in the thread
  5. Mention User D and invite User D from the Concierge whisper
  6. As User D, navigate to the thread

Expected Result:

User D can see the parent ancestor message in the thread

Actual Result:

User D can not see the parent ancestor message in the thread.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01453399d887f12ed6
  • Upwork Job ID: 1779911560255762432
  • Last Price Increase: 2024-04-22
  • Automatic offers:
    • fedirjh | Reviewer | 0
    • rayane-djouah | Contributor | 0
Issue OwnerCurrent Issue Owner: @zanyrenney

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 10, 2024
  2. melvin-bot commented on Apr 10, 2024

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. MelvinBot commented on Apr 10, 2024

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  4. brkdavis commented on Apr 10, 2024

    @brkdavis

    @m-natarajan : Tried steps in latest version of Chrome. I am not able to reproduce the issue in staging with email addresses created using same parent email (ones created using adding '+' in the email) as well as an entirely independent email address. I can see the parent of the thread for both users. Please see screenshot below.

    image

    But from a usability standpoint, it doesn't look like a parent - child tree view, rather is a flat list stating 'Thread' and 'Replies'. As an end user, I would have liked to have this view as a configurable entry.

  5. rayane-d commented on Apr 10, 2024

    @rayane-d
    Contributor

    @brkdavis this bug is currently only reproducible on main, not on staging

  6. rayane-d commented on Apr 10, 2024

    @rayane-d
    Contributor

    @m-natarajan @zanyrenney this is reproducible now on staging; it may be a deploy blocker

  7. melvin-bot commented on Apr 10, 2024

    @melvin-bot

    Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  8. 42 remaining items

  9. rayane-d commented on Apr 29, 2024

    @rayane-d
    Contributor

    PR ready for review

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 2, 2024
  11. changed the title [-][$250] [DEV]User invited by mentioning from a concierge whisper can't see parent message[/-] [+][HOLD for payment 2024-05-09] [$250] [DEV]User invited by mentioning from a concierge whisper can't see parent message[/+] on May 2, 2024
  12. melvin-bot commented on May 2, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on May 2, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-05-09. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on May 2, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@fedirjh / @rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
    • [@fedirjh / @rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@fedirjh / @rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@fedirjh / @rayane-djouah] Determine if we should create a regression test for this bug.
    • [@fedirjh / @rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. zanyrenney commented on May 8, 2024

    @zanyrenney
    Contributor

    Payment summary
    @fedirjh requires payment automatic offer (Reviewer) - paid $250 via Upwork
    @rayane-djouah requires payment automatic offer (Contributor) paid $250 via Upwork

  16. zanyrenney commented on May 8, 2024

    @zanyrenney
    Contributor

    Oh oops. I am a day early actually @fedirjh I don't imagine there will be a regression from this but please LMK if there is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorNeeds ReproductionReproducible steps neededWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions