Skip to content

[HOLD for payment] [$250] Implement offline behavior and error handling for UpdateGroupChatAvatar #39983

Closed

Description

@marcaaron

We are now able to add a custom Group chat avatar. However, we do not handle the failure case yet.

Let's take whatever we are doing for the Profile + Workspace pages and apply the same error handling here.

In the backend, we currently send exceptions like this:

Onyx::handleException($e, 'AD9240FD-A780-425D-B98D-96DD6E4251C1', OnyxKeys::COLLECTION_REPORT.$reportID, ['errorFields', 'avatar']);

Which will put an error field on the report if updating the avatar fails.

We need that error to lead the user back to the avatar and display an error message back to the user.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015da074a9479d6afc
  • Upwork Job ID: 1778152731149742080
  • Last Price Increase: 2024-04-17
  • Automatic offers:
    • s77rt | Reviewer | 0

Activity

  1. self-assigned this
    on Apr 10, 2024
  2. melvin-bot commented on Apr 10, 2024

    @melvin-bot

    Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 10, 2024

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  4. marcaaron commented on Apr 10, 2024

    @marcaaron
    ContributorAuthor

    @s77rt first dibs if you want this one before I make it External it's on HOLD for now so no need to respond right away.

  5. s77rt commented on Apr 10, 2024

    @s77rt
    Member

    I'd like to work on this

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 10, 2024
  7. changed the title [-][HOLD PR #39757] Implement offline behavior and error handling for `UpdateGroupChatAvatar`[/-] [+][$250] [HOLD PR #39757] Implement offline behavior and error handling for `UpdateGroupChatAvatar`[/+] on Apr 10, 2024
  8. melvin-bot commented on Apr 10, 2024

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 10, 2024
  10. 32 remaining items

  11. s77rt commented on May 22, 2024

    @s77rt
    Member

    Melvin, you were supposed to update the issue, didn't you used to say that issues have feeling too.

  12. nexarvo commented on Jul 7, 2024

    @nexarvo
    Contributor

    Hi @sonialiap, this was deployed to production a while ago. Can we proceed with payments here ?

  13. sonialiap commented on Jul 8, 2024

    @sonialiap
    Contributor

    @nexarvo thanks for the ping! Looks like automation didn't run here, sorry for the delay 🤖

    Payment summary:

    • @s77rt review $250 - please request in ND (or do I need to pay in upwork because you were hired before 2024-05-24?) offer sent in upwork - paid ✔️
    • @nexarvo contributor $250 - offer sent in upwork - paid ✔️
  14. changed the title [-][$250] Implement offline behavior and error handling for `UpdateGroupChatAvatar`[/-] [+][HOLD for payment] [$250] Implement offline behavior and error handling for `UpdateGroupChatAvatar`[/+] on Jul 8, 2024
  15. s77rt commented on Jul 8, 2024

    @s77rt
    Member

    @sonialiap This one is still via Upwork

  16. sonialiap commented on Jul 10, 2024

    @sonialiap
    Contributor

    @s77rt offer sent in upwork

  17. s77rt commented on Jul 10, 2024

    @s77rt
    Member

    @sonialiap Accepted! Thanks!

  18. sonialiap commented on Jul 10, 2024

    @sonialiap
    Contributor

    Paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions