Skip to content

[$250] WS - Profile - Share - Workspace QR code is not downloaded to the device #40080

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.62-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4489045
Email or phone of affected tester (no customers): applausetester+041023dr02@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Open Expensify App on mobile device
  2. Login with any account
  3. Go to any workspace > Settings > Profile or User > Settings
  4. Click on the Share button
  5. Click on the download option
  6. Verify the QR code is downloaded to the device

Expected Result:

QR code is downloaded to the device

Actual Result:

Nothing happens. Workspace QR code is NOT downloaded to the device.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6445227_1712791486535!Profile_trace_for_1.4.62-0.cpuprofile

Bug6445227_1712791486536.iOS-WS-QR-code-not-download.mp4

Bug6445227_1712791486543!App_Info_1.4.62-0.json
Bug6445227_1712791486538!logs-2024-04-10_23_13_01.025.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010fdd6488cdadd975
  • Upwork Job ID: 1778361122906787840
  • Last Price Increase: 2024-04-11

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 11, 2024
  2. melvin-bot commented on Apr 11, 2024

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 11, 2024

    @melvin-bot

    Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Apr 11, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Apr 11, 2024

    @izarutskaya
    Author

    @JmillsExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Apr 11, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 11, 2024
  8. changed the title [-]WS - Profile - Share - Workspace QR code is not downloaded to the device[/-] [+][$250] WS - Profile - Share - Workspace QR code is not downloaded to the device[/+] on Apr 11, 2024
  9. 11 remaining items

  10. added and removed on Apr 11, 2024
  11. Julesssss commented on Apr 11, 2024

    @Julesssss
    Contributor

    I agree with not blocking on this. But to avoid confusion lets hide the download button while we're awaiting a proper fix.

  12. ShridharGoel commented on Apr 12, 2024

    @ShridharGoel
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    QR code download using react-native-view-shot doesn't work after moving to the new arch.

    What is the root cause of that problem?

    The react-native-view-shot library has introduced the new architecture support in latest version, but we are still using 3.8.0. (gre/react-native-view-shot#516)

    Also, these changes in react-native need to be included.

    What changes do you think we should make in order to solve the problem?

    Add patch for the view-shot library with the changes for the new architecture or bump the version to 4.0.0-alpha.0.
    Add patch for these changes in react-native.

  13. lakchote commented on Apr 12, 2024

    @lakchote
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    QR code download using react-native-view-shot doesn't work after moving to the new arch.

    What is the root cause of that problem?

    The react-native-view-shot library has introduced the new architecture support in latest version, but we are still using 3.8.0. (gre/react-native-view-shot#516)

    Also, these changes in react-native need to be included.

    What changes do you think we should make in order to solve the problem?

    Add patch for the view-shot library with the changes for the new architecture or bump the version to 4.0.0-alpha.0. Add patch for these changes in react-native.

    I'm not a fan of patching since it's not a critical matter and the new version for react-native will fix this.

    @s77rt thoughts?

  14. WoLewicki commented on Apr 12, 2024

    @WoLewicki
    Contributor

    I'm testing bumping the version of library and adding all the proper files to react-native as a patch as part of the efforts of follow-ups to this PR: #13767. I'll try to report quickly if it is a viable option.

  15. WoLewicki commented on Apr 12, 2024

    @WoLewicki
    Contributor

    From a quick look it seems to still not work correctly after bumping the version with only the one commit mentioned here: gre/react-native-view-shot#516 (comment) is not enough to make it work on Android. Also, iOS needs bump of version and probably multiple commits to start working again too. So I think we should leave till we bump the App to RN 0.74.

  16. melvin-bot commented on Apr 19, 2024

    @melvin-bot

    @JmillsExpensify, @s77rt, @lakchote Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  17. s77rt commented on Apr 19, 2024

    @s77rt
    Member

    Oops didn't notice this on K2. Waiting for RN 0.74 seems best since the QR download button is a minor functionality. Let's close this issue since we have this tracking one #40110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions