You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Hold for payment 22 July] Unable to highlight text in mWeb or in small window size #4012
a) the isSmallScreenWidth check with !canUseTouchScreen() || !isSmallScreenWidth for 1 & 3.
b) the isSmallScreenWidth check with this.props.isSmallScreenWidth && canUseTouchScreen() && ControlSelection.block() for 2.
As a end result
We block the selection only on the M-Web Devices which have smaller screen sizes and have a touch screen.
changed the title [-]Unable to highlight text in mWeb or in small window size [/-][+][Hold for payment 22 July] Unable to highlight text in mWeb or in small window size [/+]on Jul 16, 2021
Activity
MelvinBot commentedon Jul 13, 2021
Triggered auto assignment to @MariaHCD (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.MelvinBot commentedon Jul 14, 2021
Triggered auto assignment to @laurenreidexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.parasharrajat commentedon Jul 14, 2021
We need to fix the logic that was added to fix the Context Menu on the mobile devices.
It currently blocks the selection for all Smallscreen devices which includes resized browsers on the Web and desktop.
There are three places we are blocking selection.
https://github.com/Expensify/Expensify.cash/blob/bb5ae3e99ca3ea85a0dc7505429981f5756699e0/src/pages/home/report/ReportActionItemFragment.js#L68
https://github.com/Expensify/Expensify.cash/blob/bb5ae3e99ca3ea85a0dc7505429981f5756699e0/src/pages/home/report/ReportActionItem.js#L275
https://github.com/Expensify/Expensify.cash/blob/bb5ae3e99ca3ea85a0dc7505429981f5756699e0/src/components/RenderHTML/index.js#L11
To fix this issue we need to replace
a) the
isSmallScreenWidthcheck with!canUseTouchScreen() || !isSmallScreenWidthfor1&3.b) the
isSmallScreenWidthcheck withthis.props.isSmallScreenWidth && canUseTouchScreen() && ControlSelection.block()for2.As a end result
MelvinBot commentedon Jul 14, 2021
Triggered auto assignment to @iwiznia (
Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.iwiznia commentedon Jul 15, 2021
Nice, that sounds good @parasharrajat. @laurenreidexpensify can you hire him?
laurenreidexpensify commentedon Jul 15, 2021
hired!
[-]Unable to highlight text in mWeb or in small window size [/-][+][Hold for payment 22 July] Unable to highlight text in mWeb or in small window size [/+]laurenreidexpensify commentedon Jul 22, 2021
Paid 👍🏽