Skip to content

[$250] Add back the parallax animation in the new arch #40309

Closed

Description

@roryabraham

Problem

The gyroscope parallax animation was causing serious performance issues on the new arch, so we reverted it in #40302

Solution

Address the root cause of the problem and add the animation back.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0103e0b53e212479af
  • Upwork Job ID: 1795458292540534784
  • Last Price Increase: 2024-05-28
  • Automatic offers:
    • hungvu193 | Contributor | 102495616
Issue OwnerCurrent Issue Owner: @hoangzinh

Activity

  1. roryabraham commented on Apr 16, 2024

    @roryabraham
    ContributorAuthor
  2. WoLewicki commented on Apr 16, 2024

    @WoLewicki
    Contributor

    Commenting

  3. roryabraham commented on May 3, 2024

    @roryabraham
    ContributorAuthor

    @WoLewicki any update here? I wonder if that the performance problem with the parallax animation and live markdown might actually be indicative of a broader performance regression with the new arch

  4. WoLewicki commented on May 6, 2024

    @WoLewicki
    Contributor

    Yeah, the PR is there: #41103. Sorry, I forgot to link it here. As for the regression, there still might be points where there are regressions in performance connected to the new arch and we are trying to find them and resolve each time we see any. Also, for some reason I cannot open the slack link 😕

  5. roryabraham commented on May 15, 2024

    @roryabraham
    ContributorAuthor
  6. hungvu193 commented on May 20, 2024

    @hungvu193
    Contributor

    Hey @roryabraham , since I reviewed #41103, can you reopen this to handle the payment?

  7. 8 remaining items

  8. melvin-bot commented on May 28, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  9. melvin-bot commented on May 28, 2024

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  10. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 28, 2024
  11. self-assigned this
    on May 28, 2024
  12. melvin-bot commented on May 28, 2024

    @melvin-bot

    📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  13. roryabraham commented on May 28, 2024

    @roryabraham
    ContributorAuthor

    @lschurr this is ready to pay right away, and the only payment that's due is $250 to @hungvu193 for the review

  14. lschurr commented on May 28, 2024

    @lschurr
    Contributor

    Great, all set! Payment sent to @hungvu193 in Upwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorTask

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions