You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-05-20] IOU - No bottom margin below the Save button in Merchant page #40397
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@kevinksullivan I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
changed the title [-][$250] IOU - No bottom margin below the Save button in Merchant page[/-][+][HOLD for payment] IOU - No bottom margin below the Save button in Merchant page[/+]on May 20, 2024
changed the title [-][HOLD for payment] IOU - No bottom margin below the Save button in Merchant page[/-][+][HOLD for payment 2024-05-20] IOU - No bottom margin below the Save button in Merchant page[/+]on May 20, 2024
Activity
melvin-bot commentedon Apr 18, 2024
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 18, 2024
Triggered auto assignment to @nkuoch (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 18, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Apr 18, 2024
@kevinksullivan I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Apr 18, 2024
We think this issue might be related to the #collect project.
nkdengineer commentedon Apr 18, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
There is no bottom margin below the Save button.
What is the root cause of that problem?
We removed the
styles.mb5andstyles.mt5herehttps://github.com/Expensify/App/pull/38039/files#diff-88398cd9457f0f27abc859375b1852a0b9a16e3de5da062be27e3ba55c6d02c3
App/src/components/FormAlertWithSubmitButton.tsx
Line 82 in 3ec8f2f
What changes do you think we should make in order to solve the problem?
Add
styles.mb5tocontainerStyleshere.App/src/components/Form/FormWrapper.tsx
Line 117 in 3ec8f2f
What alternative solutions did you explore? (Optional)
NA
22 remaining items
melvin-bot commentedon May 20, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01a5cc751dd16f2f72
melvin-bot commentedon May 20, 2024
Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.
[-][$250] IOU - No bottom margin below the Save button in Merchant page[/-][+][HOLD for payment] IOU - No bottom margin below the Save button in Merchant page[/+][-][HOLD for payment] IOU - No bottom margin below the Save button in Merchant page[/-][+][HOLD for payment 2024-05-20] IOU - No bottom margin below the Save button in Merchant page[/+]mountiny commentedon May 20, 2024
This is ready to be paid to @allroundexperts for $250
melvin-bot commentedon May 24, 2024
@nkuoch, @kevinksullivan, @allroundexperts, @mountiny, @lukemorawski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
allroundexperts commentedon May 25, 2024
This is good to close!
JmillsExpensify commentedon Jun 28, 2024
$250 approved for @allroundexperts