Skip to content

[HOLD for payment 2024-05-20] IOU - No bottom margin below the Save button in Merchant page #40397

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Start manual request flow.
  4. In confirmation page, click Merchant.

Expected Result:

There will be a bottom margin below the Save button.

Actual Result:

There is no bottom margin below the Save button.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6453280_1713425264720.bottom_margin.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a5cc751dd16f2f72
  • Upwork Job ID: 1792647702226952192
  • Last Price Increase: 2024-05-20
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @kevinksullivan

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 18, 2024
  2. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Apr 18, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Apr 18, 2024

    @izarutskaya
    Author

    @kevinksullivan I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Apr 18, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. nkdengineer commented on Apr 18, 2024

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    There is no bottom margin below the Save button.

    What is the root cause of that problem?

    We removed the styles.mb5 and styles.mt5 here

    https://github.com/Expensify/App/pull/38039/files#diff-88398cd9457f0f27abc859375b1852a0b9a16e3de5da062be27e3ba55c6d02c3

    containerStyles={[styles.justifyContentEnd, containerStyles]}

    What changes do you think we should make in order to solve the problem?

    Add styles.mb5 to containerStyles here.

    containerStyles={[styles.mh0, styles.mt5, submitFlexEnabled ? styles.flex1 : {}, submitButtonStyles]}

    What alternative solutions did you explore? (Optional)

    NA

  8. 22 remaining items

  9. melvin-bot commented on May 20, 2024

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 20, 2024
  11. melvin-bot commented on May 20, 2024

    @melvin-bot

    Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

  12. changed the title [-][$250] IOU - No bottom margin below the Save button in Merchant page[/-] [+][HOLD for payment] IOU - No bottom margin below the Save button in Merchant page[/+] on May 20, 2024
  13. changed the title [-][HOLD for payment] IOU - No bottom margin below the Save button in Merchant page[/-] [+][HOLD for payment 2024-05-20] IOU - No bottom margin below the Save button in Merchant page[/+] on May 20, 2024
  14. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 20, 2024
  15. mountiny commented on May 20, 2024

    @mountiny
    Contributor

    This is ready to be paid to @allroundexperts for $250

  16. melvin-bot commented on May 24, 2024

    @melvin-bot

    @nkuoch, @kevinksullivan, @allroundexperts, @mountiny, @lukemorawski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  17. allroundexperts commented on May 25, 2024

    @allroundexperts
    Contributor

    This is good to close!

  18. JmillsExpensify commented on Jun 28, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions