You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Chat – Unable to open any + menu option using Up keys and Enter, when open it first time #40399
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@kadiealexander I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Interesting, (h/t to @sonialiap for identifying this) this works the second time you press Enter but not the first, and if you navigate to another option (e.g. press enter the first time for splitting a bill, the second for editing a task) it will remember your first selection, not your second (splitting a bill). Definitely a bug 🐛
Activity
melvin-bot commentedon Apr 18, 2024
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 18, 2024
Triggered auto assignment to @NikkiWines (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 18, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Apr 18, 2024
@kadiealexander I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Apr 18, 2024
We think this issue might be related to the #vip-vsb.
izarutskaya commentedon Apr 18, 2024
Production
bandicam.2024-04-18.10-38-52-779.mp4
NikkiWines commentedon Apr 18, 2024
Interesting, (h/t to @sonialiap for identifying this) this works the second time you press
Enterbut not the first, and if you navigate to another option (e.g. press enter the first time for splitting a bill, the second for editing a task) it will remember your first selection, not your second (splitting a bill). Definitely a bug 🐛Screen.Recording.2024-04-18.at.10.26.16.mov
shahinyan11 commentedon Apr 18, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat – Unable to open any + menu option using Up keys and Enter, when open it first time
What is the root cause of that problem?
Here we call the
onItemSelectedfunction before setting the value ofselectedItemIndex.currentWhat changes do you think we should make in order to solve the problem?
Here move the
selectedItemIndex.current = indexcode above theonItemSelectedfunction callWhat alternative solutions did you explore? (Optional)
NikkiWines commentedon Apr 18, 2024
Looks like it might be a result of #39201 cc: @roryabraham @WojtekBoman
WojtekBoman commentedon Apr 18, 2024
I'll prepare a fix for that :)
roryabraham commentedon Apr 18, 2024
thanks for identifying the PR that caused this @NikkiWines 🙇🏼
roryabraham commentedon Apr 19, 2024
verified this is fixed on staging, no payments due, closing it out