Skip to content

[PAID] [$250] Leaving a group chat with 0 members inside still populates the search as a result #40493

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @johnmlee101
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713458559012729

Action Performed:

Create a group chat with some group.
Remove each of them then leave the room.

Expected Result:

Group chat should either 1. Be archived or 2. be completely inaccessible.

Actual Result:

Chat shows up like this on the search 's Group Chat and is inaccessible when clicking in.
Chrome - Latest staging

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.2986.mp4

image (3)

image (2)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d256e1494b7b0e48
  • Upwork Job ID: 1785022225889374208
  • Last Price Increase: 2024-04-29
  • Automatic offers:
    • jjcoffee | Reviewer | 0
    • bernhardoj | Contributor | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 18, 2024
  2. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. changed the title [-]Bug Leaving a group chat with 0 members inside still populates the search as a result[/-] [+]Leaving a group chat with 0 members inside still populates the search as a result[/+] on Apr 18, 2024
  5. github-actions commented on Apr 18, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. marcaaron commented on Apr 18, 2024

    @marcaaron
    Contributor

    This doesn't feel like a deploy blocker to me. @johnmlee101 I can grab this from you if you'd like as it's related to Group Chats.

  7. 19 remaining items

  8. melvin-bot commented on Apr 30, 2024

    @melvin-bot

    📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job

  9. melvin-bot commented on Apr 30, 2024

    @melvin-bot

    📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  10. added
    ReviewingHas a PR in review
    and removed on May 1, 2024
  11. bernhardoj commented on May 1, 2024

    @bernhardoj
    Contributor

    PR is ready

    cc: @jjcoffee

  12. jjcoffee commented on May 14, 2024

    @jjcoffee
    Contributor

    Looks like automation failed here, this hit production May 9, so payment is due May 16. cc @strepanier03

  13. jjcoffee commented on May 20, 2024

    @jjcoffee
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: perf: Cache search options #38207
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/38207/files#r1606552466
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug. Yes
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Create a new group chat
    2. Open the search page and verify the group chat is in the search list
    3. Open the group chat and press the header
    4. Press Leave to leave the group
    5. Open the search page again
    6. Verify the group chat isn't in the search list anymore

    Do we agree 👍 or 👎

  14. jjcoffee commented on May 20, 2024

    @jjcoffee
    Contributor

    @strepanier03 Checklist complete! Friendly bump for payment (the PR hit production May 9) 🙇

  15. changed the title [-][$250] Leaving a group chat with 0 members inside still populates the search as a result[/-] [+][Pay 2024-05-28] [$250] Leaving a group chat with 0 members inside still populates the search as a result[/+] on May 28, 2024
  16. strepanier03 commented on May 28, 2024

    @strepanier03
    Contributor

    Payments for @bernhardoj and @jjcoffee are completed via Upwork, contracts are also closed. Reg test GH is created so this is ready to be closed.

    Thank you all!

  17. changed the title [-][Pay 2024-05-28] [$250] Leaving a group chat with 0 members inside still populates the search as a result[/-] [+][PAID] [$250] Leaving a group chat with 0 members inside still populates the search as a result[/+] on May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions