You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[PAID] [$250] Leaving a group chat with 0 members inside still populates the search as a result #40493
changed the title [-]Bug Leaving a group chat with 0 members inside still populates the search as a result[/-][+]Leaving a group chat with 0 members inside still populates the search as a result[/+]on Apr 18, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Create a new group chat
Open the search page and verify the group chat is in the search list
Open the group chat and press the header
Press Leave to leave the group
Open the search page again
Verify the group chat isn't in the search list anymore
changed the title [-][$250] Leaving a group chat with 0 members inside still populates the search as a result[/-][+][Pay 2024-05-28] [$250] Leaving a group chat with 0 members inside still populates the search as a result[/+]on May 28, 2024
changed the title [-][Pay 2024-05-28] [$250] Leaving a group chat with 0 members inside still populates the search as a result[/-][+][PAID] [$250] Leaving a group chat with 0 members inside still populates the search as a result[/+]on May 28, 2024
Activity
melvin-bot commentedon Apr 18, 2024
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 18, 2024
Triggered auto assignment to @johnmlee101 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.[-]Bug Leaving a group chat with 0 members inside still populates the search as a result[/-][+]Leaving a group chat with 0 members inside still populates the search as a result[/+]github-actions commentedon Apr 18, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
marcaaron commentedon Apr 18, 2024
This doesn't feel like a deploy blocker to me. @johnmlee101 I can grab this from you if you'd like as it's related to Group Chats.
19 remaining items
melvin-bot commentedon Apr 30, 2024
📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
melvin-bot commentedon Apr 30, 2024
📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
bernhardoj commentedon May 1, 2024
PR is ready
cc: @jjcoffee
jjcoffee commentedon May 14, 2024
Looks like automation failed here, this hit production May 9, so payment is due May 16. cc @strepanier03
jjcoffee commentedon May 20, 2024
Regression Test Proposal
Do we agree 👍 or 👎
jjcoffee commentedon May 20, 2024
@strepanier03 Checklist complete! Friendly bump for payment (the PR hit production May 9) 🙇
[-][$250] Leaving a group chat with 0 members inside still populates the search as a result[/-][+][Pay 2024-05-28] [$250] Leaving a group chat with 0 members inside still populates the search as a result[/+]strepanier03 commentedon May 28, 2024
Payments for @bernhardoj and @jjcoffee are completed via Upwork, contracts are also closed. Reg test GH is created so this is ready to be closed.
Thank you all!
[-][Pay 2024-05-28] [$250] Leaving a group chat with 0 members inside still populates the search as a result[/-][+][PAID] [$250] Leaving a group chat with 0 members inside still populates the search as a result[/+]