You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Magic code not received when SAML enabled and Required for sign in disabled #40498
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This is a new feature per the OP and there is a straightforward workaround to resolve this so I am removing the deploy blocker label, but we should handle the fix with urgency
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I am adding a deploy blocker because this is not broken on production even if the UI is slightly different. Since it's blocking signing in, it is not great, it's not a minor bug.
Activity
melvin-bot commentedon Apr 18, 2024
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 18, 2024
Triggered auto assignment to @bondydaa (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 18, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
mountiny commentedon Apr 19, 2024
This is a new feature per the OP and there is a straightforward workaround to resolve this so I am removing the deploy blocker label, but we should handle the fix with urgency
12 remaining items
github-actions commentedon Apr 22, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
pecanoro commentedon Apr 22, 2024
I am adding a deploy blocker because this is not broken on production even if the UI is slightly different. Since it's blocking signing in, it is not great, it's not a minor bug.
mountiny commentedon Apr 22, 2024
Going to revert to the previous behaviour then #40690
pecanoro commentedon Apr 22, 2024
@mountiny After reverting, now I am getting this error even after getting rid of Onyx data, are we missing something? https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%228785f326fdad2177-MAD%22)+AND+timestamp:[2024-04-22T12:27:11.309Z+TO+2024-04-22T14:27:11.309Z]&index=logs_expensify-027957
mountiny commentedon Apr 22, 2024
It works as expected for me
Uploading Screen Recording 2024-04-22 at 15.42.00.mov…
pecanoro commentedon Apr 22, 2024
Hmm, yes, it only happens for one of my accounts, super weird. All good then, I will look into it later
mountiny commentedon Apr 22, 2024
the recording was too big
Screen.Recording.2024-04-22.at.15.45.58.mp4