Skip to content

Magic code not received when SAML enabled and Required for sign in disabled #40498

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: No new feature (Production UI is different)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @johnmlee101
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713457220310039

Action Performed:

  1. Enter an email with SAML optionally enabled (not required on domain) on the sign in page
  2. See page for entering magic code or selecting SAML

Expected Result:

Receive a magic code email

Actual Result:

No magic code received, user has to wait for 30 seconds to show Didn't receive code and 2nd request works

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.2989.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 18, 2024
  2. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Apr 18, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 19, 2024
  6. mountiny commented on Apr 19, 2024

    @mountiny
    Contributor

    This is a new feature per the OP and there is a straightforward workaround to resolve this so I am removing the deploy blocker label, but we should handle the fix with urgency

  7. 12 remaining items

  8. github-actions commented on Apr 22, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  9. pecanoro commented on Apr 22, 2024

    @pecanoro
    Contributor

    I am adding a deploy blocker because this is not broken on production even if the UI is slightly different. Since it's blocking signing in, it is not great, it's not a minor bug.

  10. mountiny commented on Apr 22, 2024

    @mountiny
    Contributor

    Going to revert to the previous behaviour then #40690

  11. pecanoro commented on Apr 22, 2024

    @pecanoro
    Contributor
  12. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 22, 2024
  13. mountiny commented on Apr 22, 2024

    @mountiny
    Contributor

    It works as expected for me
    Uploading Screen Recording 2024-04-22 at 15.42.00.mov…

  14. pecanoro commented on Apr 22, 2024

    @pecanoro
    Contributor

    Hmm, yes, it only happens for one of my accounts, super weird. All good then, I will look into it later

  15. mountiny commented on Apr 22, 2024

    @mountiny
    Contributor

    the recording was too big

    Screen.Recording.2024-04-22.at.15.45.58.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions