Skip to content

[HOLD for payment 2024-05-08] [$250] Task - "From" subtitle is present in group task report after user has left the group #40499

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to group chat
  3. Create a task
  4. Click on the chat header > Leave
  5. Go to task report
  6. Click on "From" link

Expected Result:

There should not be "From" link because the group chat is no longer accessible

Actual Result:

There is "From" link in the task report when user has left the group chat. Clicking on "From" subtitle leads to skeleton report.
The same issue also happens for group thread after user leaves the group chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453890_1713458808249.bandicam_2024-04-19_00-43-34-829.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017c5bacf8c885bcc7
  • Upwork Job ID: 1781098555062116352
  • Last Price Increase: 2024-04-18
Issue OwnerCurrent Issue Owner: @miljakljajic

Activity

  1. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Apr 18, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. lanitochka17 commented on Apr 18, 2024

    @lanitochka17
    Author

    @luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Apr 18, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  5. luacmartins commented on Apr 18, 2024

    @luacmartins
    Contributor

    Looking

  6. luacmartins commented on Apr 18, 2024

    @luacmartins
    Contributor

    I can reproduce on staging, but not locally. Investigating

  7. luacmartins commented on Apr 18, 2024

    @luacmartins
    Contributor

    I'm gonna demote this since it doesn't break any functionality

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 18, 2024
  9. 16 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 1, 2024
  11. changed the title [-][$250] Task - "From" subtitle is present in group task report after user has left the group[/-] [+][HOLD for payment 2024-05-08] [$250] Task - "From" subtitle is present in group task report after user has left the group[/+] on May 1, 2024
  12. melvin-bot commented on May 1, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on May 1, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-05-08. 🎊

    For reference, here are some details about the assignees on this issue:

    • @eVoloshchak requires payment through NewDot Manual Requests
  14. melvin-bot commented on May 1, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
    • [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@eVoloshchak] Determine if we should create a regression test for this bug.
    • [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. miljakljajic commented on May 7, 2024

    @miljakljajic
    Contributor

    @eVoloshchak are you owed payment for reviewing the PR? I'll submit a manual request for you tomorrow.

  16. eVoloshchak commented on May 7, 2024

    @eVoloshchak
    Contributor

    are you owed payment for reviewing the PR?

    @miljakljajic, yes, for the review of #40726

  17. miljakljajic commented on May 8, 2024

    @miljakljajic
    Contributor

    @eVoloshchak is owed 250 USD for their work reviewing #40726

    Thank you!

  18. JmillsExpensify commented on May 12, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @eVoloshchak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions