You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-05-08] [$250] Task - "From" subtitle is present in group task report after user has left the group #40499
Version Number: 1.4.63-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to group chat
Create a task
Click on the chat header > Leave
Go to task report
Click on "From" link
Expected Result:
There should not be "From" link because the group chat is no longer accessible
Actual Result:
There is "From" link in the task report when user has left the group chat. Clicking on "From" subtitle leads to skeleton report.
The same issue also happens for group thread after user leaves the group chat
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-][$250] Task - "From" subtitle is present in group task report after user has left the group[/-][+][HOLD for payment 2024-05-08] [$250] Task - "From" subtitle is present in group task report after user has left the group[/+]on May 1, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
[@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@eVoloshchak] Determine if we should create a regression test for this bug.
[@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Apr 18, 2024
Triggered auto assignment to @luacmartins (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 18, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Apr 18, 2024
@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Apr 18, 2024
We think that this bug might be related to #vip-vsp
luacmartins commentedon Apr 18, 2024
Looking
luacmartins commentedon Apr 18, 2024
I can reproduce on staging, but not locally. Investigating
luacmartins commentedon Apr 18, 2024
I'm gonna demote this since it doesn't break any functionality
16 remaining items
[-][$250] Task - "From" subtitle is present in group task report after user has left the group[/-][+][HOLD for payment 2024-05-08] [$250] Task - "From" subtitle is present in group task report after user has left the group[/+]melvin-bot commentedon May 1, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 1, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-05-08. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 1, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
miljakljajic commentedon May 7, 2024
@eVoloshchak are you owed payment for reviewing the PR? I'll submit a manual request for you tomorrow.
eVoloshchak commentedon May 7, 2024
@miljakljajic, yes, for the review of #40726
miljakljajic commentedon May 8, 2024
@eVoloshchak is owed 250 USD for their work reviewing #40726
Thank you!
JmillsExpensify commentedon May 12, 2024
$250 approved for @eVoloshchak