Skip to content

[HOLD for payment July 22] Update line break regex for HTML->Markdown to support break tags with styles #4052

Closed

Description

@Jag96

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


More context in #4009 (comment), this is part of #3047, @parasharrajat will handle as a follow-up

Action Performed:

  1. Copy the following text:

Bold text
italic text
Strikethrough text

  1. Paste the text in e.cash

Expected Result:

Line breaks should be included in the pasted message

Actual Result:

Line breaks aren't included in the pasted message

image

Workaround:

The user has to manually insert line breaks

Platform:

Web

Version Number: 1.0.77-6

View all open jobs on Upwork

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 14, 2021
  2. self-assigned this
    on Jul 14, 2021
  3. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 14, 2021
  4. added and removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 14, 2021
  5. parasharrajat commented on Jul 14, 2021

    @parasharrajat
    Member
    1. It is straightforward like we did for Italic.
      <br(?:"[^"]*"|'[^']*'|[^'">])*>(?![^<]*(<\/pre>|<\/code>))\n?

    We need to exclude pre and code tags and Allow any attribute between start tags, with one exception there is no end tag here.

  6. isagoico commented on Jul 15, 2021

    @isagoico

    Let us know when #3047 is fixed so we can retest this PR :)

  7. changed the title [-]Update line break regex for HTML->Markdown to support break tags with styles[/-] [+][HOLD for payment July 22] Update line break regex for HTML->Markdown to support break tags with styles[/+] on Jul 15, 2021
  8. Jag96 commented on Jul 16, 2021

    @Jag96
    ContributorAuthor

    We're going to be doing #3047 in pieces, so #4009 is the latest PR (on staging) to test for this!

  9. Jag96 commented on Jul 22, 2021

    @Jag96
    ContributorAuthor

    Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions