Skip to content

[HOLD for payment 2024-05-13] [$250] Web - Pressing on keyboard enter key on notification option of a room takes back two steps #40551

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail: EXP around https://expensify.testrail.io/index.php?/tests/view/4494233
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create a room
  3. Open the room page
  4. Click on header
  5. Click on settings
  6. Click on Notify me about new messages
  7. Select a notification preference option by using the keyboard arrow keys
  8. Press enter on one of the options

Expected Result:

App should navigate to Settings page

Actual Result:

App navigates to Room details page

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6454735_1713521652242.bandicam_2024-04-19_13-08-56-915.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01889a2544214bb02d
  • Upwork Job ID: 1781342777391833088
  • Last Price Increase: 2024-04-19
  • Automatic offers:
    • suneox | Contributor | 0
Issue OwnerCurrent Issue Owner: @kevinksullivan

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 19, 2024
  2. melvin-bot commented on Apr 19, 2024

    @melvin-bot

    Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 19, 2024

    @melvin-bot

    Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Apr 19, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. kavimuru commented on Apr 19, 2024

    @kavimuru
    Author

    @mountiny FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. kavimuru commented on Apr 19, 2024

    @kavimuru
    Author

    We think this bug might be related to #vip-vsb

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 19, 2024
  8. changed the title [-]Web - Pressing on keyboard enter key on notification option of a room takes back two steps[/-] [+][$250] Web - Pressing on keyboard enter key on notification option of a room takes back two steps[/+] on Apr 19, 2024
  9. 38 remaining items

  10. suneox commented on Apr 25, 2024

    @suneox
    Contributor

    The PR has been deployed to production 3 days ago, I think we should update hold for payment

  11. suneox commented on Apr 30, 2024

    @suneox
    Contributor

    Hi @mountiny This issue has been deployed to production over 1 week, so I think we should process payment. Thank you!

  12. suneox commented on May 3, 2024

    @suneox
    Contributor

    Friendly bump @mountiny

  13. suneox commented on May 11, 2024

    @suneox
    Contributor

    @mountiny could you please process payment for this issue?

  14. changed the title [-][$250] Web - Pressing on keyboard enter key on notification option of a room takes back two steps[/-] [+][HOLD for payment 2024-05-13] [$250] Web - Pressing on keyboard enter key on notification option of a room takes back two steps[/+] on May 13, 2024
  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on May 13, 2024
  16. kevinksullivan commented on May 13, 2024

    @kevinksullivan
    Contributor

    Payment summary:

  17. JmillsExpensify commented on Jun 17, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions