Skip to content

QAB - Shortcut for manual request show as "Track expense" instead of "Track manual" #40554

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when validating #39640
Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Navigate to staging.new.expensify.com & log in
  2. Open the self-DM chat or WS chat
  3. Click + > Track Expense and follow the process to add a manual track expense
  4. Click + FAB icon & observe shortcut shown as "Track expense" instead of "Track manual"

Expected Result:

Shortcut for manual track expense should show as "Track manual" instead of "Track expense"

Actual Result:

Shortcut for manual track request show as "Track expense" instead of "Track manual"

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6454407_1713491834074!Screenshot__186_

Bug6454407_1713491834084.Recording__147.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 19, 2024
  2. melvin-bot commented on Apr 19, 2024

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. kavimuru commented on Apr 19, 2024

    @kavimuru
    Author

    @mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  4. ZhenjaHorbach commented on Apr 19, 2024

    @ZhenjaHorbach
    Contributor

    Looks like regression from this PR
    fcfa4d4#diff-2a9066512656fa29b1565e362127de5cc11ba95b28f143a9db26f76dc3750785R605

    Or it's expected

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    QAB - Shortcut for manual request show as "Track expense" instead of "Track manual

    What is the root cause of that problem?

    The main problem with issue is that we have incorrect text for trackManual

    What changes do you think we should make in order to solve the problem?

    To fix this issue we can update this text

    fcfa4d4#diff-2a9066512656fa29b1565e362127de5cc11ba95b28f143a9db26f76dc3750785R605

    What alternative solutions did you explore? (Optional)

    NA

  5. FitseTLT commented on Apr 19, 2024

    @FitseTLT
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Shortcut for manual request show as "Track expense" instead of "Track manual"

    What is the root cause of that problem?

    Wrong text here

    trackManual: 'Track expense',

    What changes do you think we should make in order to solve the problem?

    Change it to

            trackManual: 'Track manual',
    
    

    What alternative solutions did you explore? (Optional)

  6. allgandalf commented on Apr 19, 2024

    @allgandalf
    Contributor

    The result is expected, we changed the text here #40324

    c.c. @mallenexpensify @Gonals

  7. mallenexpensify commented on Apr 19, 2024

    @mallenexpensify
    Contributor

    Thanks @GandalfGwaihir , I've def been a lil tripped up this week with some of the updated around 'request money' to 'submit expense' and also 'track expense'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions