Skip to content

[HOLD for payment 2024-05-06] [$125] Sending image with message has ' appears as HTML for temporarily until the image appears fully #40578

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713478343633609

Action Performed:

  1. Open any chat
  2. Write a message like "It's breaking" with apostrophe
  3. Paste an image and send the image

Expected Result:

Text is sent without any weirdness

Actual Result:

Message appears as it's breaking

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.2995.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0192ead78ec42f211a
  • Upwork Job ID: 1782467123537166336
  • Last Price Increase: 2024-04-22
  • Automatic offers:
    • rojiphil | Reviewer | 0
    • ShridharGoel | Contributor | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 19, 2024
  2. melvin-bot commented on Apr 19, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 19, 2024

    @melvin-bot

    Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Apr 19, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. changed the title [-]Sending image with message has `'` appears as HTML for temporarily after sending until the image appears fully[/-] [+]Sending image with message has `'` appears as HTML for temporarily until the image appears fully[/+] on Apr 19, 2024
  6. amyevans commented on Apr 19, 2024

    @amyevans
    Contributor

    Reproducible in production?: y

    I don't think this is accurate, I cannot repro in prod.

    Since the message gets corrected by the server I'd consider it a minor issue and not something that needs to block deploy.

    That said, I believe all that's needed to fix the bug is updating this line

    textForNewComment = `${commentText}\n${CONST.ATTACHMENT_UPLOADING_MESSAGE_HTML}`;
    to

    textForNewComment = `${parser.htmlToText(commentText)}\n${CONST.ATTACHMENT_UPLOADING_MESSAGE_HTML}`;

    @tgolen do you want to take this one as polish to your feature?

  7. added and removed on Apr 19, 2024
  8. 36 remaining items

  9. self-assigned this
    on May 3, 2024
  10. sakluger commented on May 3, 2024

    @sakluger
    Contributor

    @greg-schroeder can you handle payment on Monday since I'll be OOO? Here are the Upwork offer links.

  11. melvin-bot commented on May 7, 2024

    @melvin-bot

    @rojiphil, @sakluger, @amyevans, @greg-schroeder, @ShridharGoel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  12. greg-schroeder commented on May 7, 2024

    @greg-schroeder
    Contributor

    Taking care of payments

  13. greg-schroeder commented on May 7, 2024

    @greg-schroeder
    Contributor

    @ShridharGoel you have to accept the offer in Upwork before we can pay you, FYI!

  14. greg-schroeder commented on May 7, 2024

    @greg-schroeder
    Contributor

    @rojiphil can you take care of the checklist above?

  15. sakluger commented on May 7, 2024

    @sakluger
    Contributor

    Thanks Greg! Taking back over.

    Just waiting for @ShridharGoel to accept the Upwork offer and @rojiphil to complete the BZ Checklist before we can close the issue.

  16. rojiphil commented on May 8, 2024

    @rojiphil
    Contributor
    • [@rojiphil] The PR that introduced the bug has been identified. Link to the PR: Offending PR
    • [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Added comment
    • [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required. The existing checklist is good enough to capture such issues.
    • [@rojiphil] Determine if we should create a regression test for this bug. : I don’t think this is required
    • [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  17. rojiphil commented on May 8, 2024

    @rojiphil
    Contributor

    and @rojiphil to complete the BZ Checklist

    @sakluger BZ Checklist is completed.

  18. sakluger commented on May 9, 2024

    @sakluger
    Contributor

    Thanks! I paid @ShridharGoel so we're all good here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions