You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-05-06] [$125] Sending image with message has ' appears as HTML for temporarily until the image appears fully #40578
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Sending image with message has `'` appears as HTML for temporarily after sending until the image appears fully[/-][+]Sending image with message has `'` appears as HTML for temporarily until the image appears fully[/+]on Apr 19, 2024
[@rojiphil] The PR that introduced the bug has been identified. Link to the PR: Offending PR
[@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Added comment
[@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required. The existing checklist is good enough to capture such issues.
[@rojiphil] Determine if we should create a regression test for this bug. : I don’t think this is required
[@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Apr 19, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 19, 2024
Triggered auto assignment to @amyevans (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 19, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
[-]Sending image with message has `'` appears as HTML for temporarily after sending until the image appears fully[/-][+]Sending image with message has `'` appears as HTML for temporarily until the image appears fully[/+]amyevans commentedon Apr 19, 2024
I don't think this is accurate, I cannot repro in prod.
Since the message gets corrected by the server I'd consider it a minor issue and not something that needs to block deploy.
That said, I believe all that's needed to fix the bug is updating this line
App/src/libs/ReportUtils.ts
Line 3206 in 09ad468
@tgolen do you want to take this one as polish to your feature?
36 remaining items
sakluger commentedon May 3, 2024
@greg-schroeder can you handle payment on Monday since I'll be OOO? Here are the Upwork offer links.
melvin-bot commentedon May 7, 2024
@rojiphil, @sakluger, @amyevans, @greg-schroeder, @ShridharGoel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
greg-schroeder commentedon May 7, 2024
Taking care of payments
greg-schroeder commentedon May 7, 2024
@ShridharGoel you have to accept the offer in Upwork before we can pay you, FYI!
greg-schroeder commentedon May 7, 2024
@rojiphil can you take care of the checklist above?
sakluger commentedon May 7, 2024
Thanks Greg! Taking back over.
Just waiting for @ShridharGoel to accept the Upwork offer and @rojiphil to complete the BZ Checklist before we can close the issue.
rojiphil commentedon May 8, 2024
rojiphil commentedon May 8, 2024
@sakluger BZ Checklist is completed.
sakluger commentedon May 9, 2024
Thanks! I paid @ShridharGoel so we're all good here.