Skip to content

Chat - Mention containing valid report ID is not clickable and invalid # is not styled #40582

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.63-7
Reproducible in staging?: y
Reproducible in production?: y
Issue found when executing PR: #39906
Reported: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to chat.
  3. Send text containing the following mention with # :
  • valid report ID
  • invalid report ID
  • invalid room name

Expected Result:

image

Actual Result:

image

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6454714_1713520407882.20240419_174807.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 19, 2024
  2. melvin-bot commented on Apr 19, 2024

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. kbecciv commented on Apr 19, 2024

    @kbecciv
    Author

    We think that this bug might be related to #vip-vsb

  4. kbecciv commented on Apr 19, 2024

    @kbecciv
    Author

    @jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  5. mountiny commented on Apr 20, 2024

    @mountiny
    Contributor
  6. jliexpensify commented on Apr 22, 2024

    @jliexpensify
    Contributor

    Can't assign @robertKozik until he comments, but have assigned Puneet for this regression.

  7. robertKozik commented on Apr 22, 2024

    @robertKozik
    Contributor

    Hi! Looking into it, thanks for pinging me here!

  8. robertKozik commented on Apr 22, 2024

    @robertKozik
    Contributor

    I think we have a little misunderstanding there. User is able to mention rooms only by their names. ReportID values are embedded into HTML attributes of mention tag, and are done on the backend side.
    While trying to type mention by id, parser will correctly recognise it as proper mention (as numbers are valid room name), but the typed value would be assume as room name.

    But I think we can be. more consistent while we are working on optimistic version of the message, as we will want to remove as much as possible jumping between highlighted -> non-highlighted states when getting the response from the backend.

  9. puneetlath commented on Apr 23, 2024

    @puneetlath
    Contributor

    Yes, I think we can close. This is just a misunderstanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions